Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A public property must be of type string, so that it remains editable in PropertyGrid. However, password should be stored in a SecureString backing variable. Conversion from plain string to SecureString happens whenever the Setter() is called. The Getter() returns a default password that is only to allow the GUI to show that a password has been added. Calling the Getter() will NOT return the plaintext password. There is a helper functions to access Plaintext password only when required, which should be at the point of connection, or during unit tests.
Added more secure encrypt/decrypt functions where required to avoid early conversion from SecureString to string.
Motivation and Context
Fixes issue-2630
How Has This Been Tested?
Confirmed through manual testing that password can be edited, and the edit is persisted.
Same # unit tests are passing as previous builds.
Screenshots (if appropriate):
Types of changes
Checklist: