Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression of issue described in #1959 #2617

Open
jdmcnair opened this issue Jul 16, 2024 · 3 comments
Open

Regression of issue described in #1959 #2617

jdmcnair opened this issue Jul 16, 2024 · 3 comments
Assignees
@Kvarkas
Labels
1.76.20 Version 1.76.20 1.77.3 Version 1.77.3 Need 2 check Settings update update related

Comments

@jdmcnair
Copy link
Contributor

Expected Behavior

When starting up the mRemoteNG application, the application should not fail to load if an update check fails to reach the update server.
The update check, should it fail to reach the server, should handle the failure gracefully and open the application anyway.

Current Behavior

It fails to open when the update server is not reachable. This is a regression of issue #1959, which was fixed in PR #1960.

Possible Solution

It looks like the regression happened in a subsequent refactor of the area of the fix submitted in #1960.

Steps to Reproduce (for bugs)

  1. Attempt to open mRemoteNG on a network where the server or firewall is blocked.
  2. See failure to open.

Context

It has been several months since I noticed a regression in an update. Not sure when the regression actually happened, but seeing the fix in #1960, and when it that code was wiped out, should be informative.

Your Environment

  • Version used: 1.76.20.24615
  • Operating System and version (e.g. Windows 10 1709 x64): Windows 11 23H2 x64
@simonai1254
Copy link
Contributor

Hi

You reported the issue for the same version twice. I wouldn't call it a regression if you compare it to the the identical build which already had the flaw in it.
As far as I'm aware the code is now integrated into 1.77. Anyhow the updater needs work for sure, and a lot of information related to that can be found in issue #2541

Regards
Simon

@Kvarkas Kvarkas added the 1.76.20 Version 1.76.20 label Jul 16, 2024
@jdmcnair
Copy link
Contributor Author

Hmm, I'm confused. I really don't know how I'm on that version again. I submitted a fix for this issue in #1960, and I could swear at some point I saw that the issue was no longer happening on a subsequent version. Maybe I uninstalled/reinstalled at some point and got the "latest" release, and didn't get the version with the fix because everything after 1.76.20 is pre-release. I'll try one of the later versions. Sorry to waste your time.

@Kvarkas
Copy link
Member

Kvarkas commented Jul 17, 2024

whats ok, please check on what branch you are, latest is 1.77.3-dev

@Kvarkas Kvarkas self-assigned this Jul 23, 2024
@Kvarkas Kvarkas added Need 2 check 1.77.3 Version 1.77.3 update update related Settings labels Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kvarkas Kvarkas

Labels
1.76.20 Version 1.76.20 1.77.3 Version 1.77.3 Need 2 check Settings update update related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Kvarkas @jdmcnair @simonai1254