fix bugs when running easy simple server (sotopia-lab#144)

* fix bugs in easy simple server * fix an error occured in type checking of langchain
lwaekfjlk · Sep 25, 2023 · 1ecd841 · 1ecd841
1 parent 036caf3
commit 1ecd841
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/sotopia/generation_utils/langchain_callback_handler.py b/sotopia/generation_utils/langchain_callback_handler.py
@@ -34,7 +34,7 @@ def on_tool_end(
         pass
 
     def on_tool_error(
-        self, error: Exception | KeyboardInterrupt, **kwargs: Any
+        self, error: BaseException | KeyboardInterrupt, **kwargs: Any
     ) -> None:
         """Do nothing."""
         pass

diff --git a/sotopia/server.py b/sotopia/server.py
@@ -217,7 +217,7 @@ async def arun_one_episode(
 @beartype
 async def run_async_server(
     model_dict: dict[str, LLM_Name],
-    sampler: BaseSampler[Observation, AgentAction],
+    sampler: BaseSampler[Observation, AgentAction] = UniformSampler(),
     action_order: Literal[
         "simutaneous", "round-robin", "random"
     ] = "round-robin",

diff --git a/sotopia_conf/server.py b/sotopia_conf/server.py
@@ -18,16 +18,14 @@
 
 
 def main(_: Any) -> None:
-    run_async_server_gin = gin.configurable(run_async_server)
-
     parse_gin_flags(
         # User-provided gin paths take precedence if relative paths conflict.
         FLAGS.gin_search_paths + _DEFAULT_GIN_SEARCH_PATHS,
         FLAGS.gin_file,
         FLAGS.gin_bindings,
     )
 
-    asyncio.run(run_async_server_gin())  # type: ignore[call-arg]
+    asyncio.run(run_async_server())  # type: ignore[call-arg]
 
 
 if __name__ == "__main__":