Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: simplify the find_version script and fix shellcheck report in it #6133

Merged
merged 2 commits into from
May 3, 2024
Merged

docs: simplify the find_version script and fix shellcheck report in it #6133

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0534ef
feat(docs): simplify the find_version script
Apr 26, 2024
243ca93
fix(docs): fix shellcheck SC2164 on possibly failing cd builtin
Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(docs): fix shellcheck SC2164 on possibly failing cd builtin 
Fix the following shellcheck report. The cd builtin may fail, handle it gracefully.
"
In scripts/find_version.sh line 3:
SCRIPTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )"
               ^-- SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.

Did you mean:
SCRIPTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 || exit ; pwd -P )"

For more information:
  https://www.shellcheck.net/wiki/SC2164 -- Use 'cd ... || exit' or 'cd ... |...
"

Signed-off-by: Marek Vasut <marex@denx.de>
  • Loading branch information
Marek Vasut committed Apr 26, 2024
commit 243ca93e892f6cc8f2ddf6cb5954a15570440954
2 changes: 1 addition & 1 deletion scripts/find_version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/sh

SCRIPTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 ; pwd -P )"
SCRIPTPATH="$( cd -- "$(dirname "$0")" >/dev/null 2>&1 || exit ; pwd -P )"
sed -n '/LVGL_VERSION_MAJOR/ {N;s@#define \+LVGL_VERSION_M.... \+@@g;s@\n@.@p}' "$SCRIPTPATH/../lv_version.h"
Loading