esp32 support #68
Merged
esp32 support #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fbiego
commented
Nov 28, 2024
fbiego
commented
- add esp32 support (arduino framework)
- change main file to c++ (arduino compatibility)
- add support for esp32 (tested with wt32 480x320)
- add esp32 support (arduino framework) - change main file to c++ (arduino compatibility) - add support for esp32 (tested with wt32 480x320)
kisvegabor
reviewed
Nov 28, 2024
| #endif | ||
|
|
||
|
|
||
| void hal_setup(void); |
There was a problem hiding this comment.
Suggested change
| void hal_setup(void); | |
| /** | |
| * Add some description please | |
| */ | |
| void hal_setup(void); |
There was a problem hiding this comment.
I meant add some description please as API comments 🙂
Co-authored-by: Gabor Kiss-Vamosi <kisvegabor@gmail.com>
Co-authored-by: Gabor Kiss-Vamosi <kisvegabor@gmail.com>
Co-authored-by: Gabor Kiss-Vamosi <kisvegabor@gmail.com>
Co-authored-by: Gabor Kiss-Vamosi <kisvegabor@gmail.com>
Co-authored-by: Gabor Kiss-Vamosi <kisvegabor@gmail.com>
add comments
kisvegabor
reviewed
Dec 2, 2024
kisvegabor
approved these changes
Dec 2, 2024
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.