Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why IntoIter and Extend are generated only for pub types #71

Closed
ihor-rud opened this issue Jan 4, 2025 · 1 comment · Fixed by #72
Closed

Why IntoIter and Extend are generated only for pub types #71

ihor-rud opened this issue Jan 4, 2025 · 1 comment · Fixed by #72

Comments

@ihor-rud
Copy link

ihor-rud commented Jan 4, 2025

I noticed that soa-derive does not generate IntoIterator and Extend implementations for types that have pub(crate) visibility. Is there a reason for that?
@ihor-rud ihor-rud changed the title Why IntoIter and Extend is generated only for pub types Why IntoIter and Extend are generated only for pub types Jan 4, 2025
@Luthaf
Copy link
Member

Luthaf commented Jan 6, 2025

I can't remember why, and I can't find a good reason to keep it this way, so I'll change it!

@Luthaf Luthaf mentioned this issue Jan 6, 2025
Merged
@Luthaf Luthaf closed this as completed in #72 Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve visibility of iterator methods and helper structs lumol-org/soa-derive
2 participants
@Luthaf @ihor-rud