Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Alamofire/Alamofire
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: lowlevel-studios/Alamofire
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 175 files changed
  • 2 contributors

Commits on Nov 5, 2018

  1. If string creation with a specific encoding fails, fallback to ASCII …

    …encoding before returning error.
    lowlevel-mboton authored and Miguel Boton committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    74b3f53 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2019

  1. [Issue #2677] Fixed reachability listener issue in airplane mode

    Prior to this change, the reachability listener was notified at launch if the device was not in airplane mode. When in airplane mode, the reachability flags were 0, which is what we were defaulting the previous flags to. Because of this, the notifyListener function would early out since the flags had not changed.
    
    The core issue here was that the default value of previousFlags was poorly chosen. It should instead default to a value that represents and unknown status. One way to do this would be to make previousFlags an optional. However, this change would not be backwards compatible, so it was abandoned.
    
    The best backwards compatible way to make this change was to set previousFlags to a rawValue that is not currently used. That way, we can guarantee that the originally computed flags will be different than the default previous flags. This change results in the listener being called at launch even when in airplane mode.
    
    Please refer to issue #2677 for more details.
    cnoon committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    4711de7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4b14a97 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8219072 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    13b3e10 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d82c794 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2019

  1. Configuration menu
    Copy the full SHA
    88182e9 View commit details
    Browse the repository at this point in the history
Loading