Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a deadlock in the consumer mock #451

Merged
merged 1 commit into from
Apr 28, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix a deadlock in the consumer mock
  • Loading branch information
moonpolysoft committed Apr 25, 2024
commit fdd1ae51ff06bae9d880845b9b3015d45a1e0544
4 changes: 3 additions & 1 deletion mockautoconsumers.go
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,9 @@ func (pc *MockAutoPartitionConsumer) Close() error {
pc.t.Errorf("Expected the messages channel for %s/%d to be drained on close, but found %d messages.", pc.topic, pc.partition, len(pc.messages))
}

pc.AsyncClose()
close(pc.messages)
close(pc.errors)
pc.consumed = false

var (
closeErr error
Expand Down
Loading