fix a deadlock in the consumer mock #451
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a deadlock in the
MockAutoPartitionConsumer
. TheClose()
function does all of its work from within async.Once
. However, theAsyncClose()
function utilizes the samesync.Once
to do its work.Close()
callsAsyncClose()
from within the once invocation and results in a deadlock as the mutex is being held by the outerClose()
.This change inlines the operations
AsyncClose()
would've performed into the main body ofClose()
, removing the possibility for deadlock.