Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/issue template modification for v2 #4240

Merged
merged 13 commits into from
Jan 25, 2024
Merged

chore/issue template modification for v2 #4240

merged 13 commits into from
Jan 25, 2024

Conversation

CommanderStorm
Copy link
Collaborator

@CommanderStorm CommanderStorm commented Dec 15, 2023 •
edited
Loading

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

As discussed in #4171 some modifications to our issue template are likely neccesary before launching v2.0
This PR is the discussion for this modification

Type of change

Please delete any options that are not relevant.

  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings

Screenshots (if any)

@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Dec 15, 2023
@louislam
Copy link
Owner

louislam commented Dec 15, 2023 •
edited
Loading

Is it possible to enable "Issues" in your fork? So that I can preview it.

@CommanderStorm CommanderStorm marked this pull request as draft December 15, 2023 12:00
@CommanderStorm CommanderStorm marked this pull request as ready for review December 15, 2023 12:21
@CommanderStorm
Copy link
Collaborator Author

Is it possible to enable "Issues" in your fork? So that I can preview it.

I have changed the repo settings: https://github.com/CommanderStorm/uptime-kuma/issues/new/choose

chakflying
chakflying reviewed Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@chakflying chakflying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit weird that related-issues and no-duplicate-issues are both marked as required. I think would make sense to fill out either one or the other.

Maybe we can merge them, just use the textarea and say "or explain that you are unable to find any related issues".

.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
@chakflying
Copy link
Collaborator

Also, I think GitHub has a bug as the inline editor would overlay "leave a comment" on top of the placeholder. I'm using Firefox on Windows.

image

@louislam
Copy link
Owner

Chrome too

image

CommanderStorm and others added 2 commits December 16, 2023 14:49
@CommanderStorm @chakflying
suggested rewording
26e9ed6 
Co-authored-by: Nelson Chan <3271800+chakflying@users.noreply.github.com>
@CommanderStorm
removed the duplicate checkbox
d77f537
@CommanderStorm
Copy link
Collaborator Author

I don't know what would be the best way to go around this. This seems to be a GitHub bug.
Upvoting https://github.com/orgs/community/discussions/76763 may help.

I could make all placeholder's into pre-filled values, but users would likely not remove that..

@CommanderStorm CommanderStorm added the area:core issues describing changes to the core of uptime kuma label Dec 16, 2023
chakflying
chakflying reviewed Dec 16, 2023
View reviewed changes
Copy link
Collaborator

@chakflying chakflying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency with the Bug Report Template.

.github/ISSUE_TEMPLATE/ask-for-help.yaml Outdated Show resolved Hide resolved
@CommanderStorm @chakflying
suggested rewording
bb14696 
Co-authored-by: Nelson Chan <3271800+chakflying@users.noreply.github.com>
@louislam
Copy link
Owner

https://github.com/orgs/community/discussions/76763

It seems that they fixed the issue, it can be merged now.

@louislam louislam merged commit 538f832 into louislam:master Jan 25, 2024
17 checks passed
@CommanderStorm CommanderStorm deleted the chore/issue-template branch January 26, 2024 11:29
@CommanderStorm CommanderStorm mentioned this pull request Feb 11, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chakflying chakflying chakflying left review comments

@louislam louislam Awaiting requested review from louislam

Assignees
No one assigned
Labels
area:core issues describing changes to the core of uptime kuma
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@CommanderStorm @louislam @chakflying