Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for selecting HTTP client version (HTTP/1.0, HTTP/1.1, HTTP/2, HTTP/3) #4559

Open
ilogus opened this issue Mar 7, 2024 · 3 comments
Open

Support for selecting HTTP client version (HTTP/1.0, HTTP/1.1, HTTP/2, HTTP/3) #4559

ilogus opened this issue Mar 7, 2024 · 3 comments
Labels
area:monitor Everything related to monitors blocked-upstream upstream (i.e. a dependency we depend on will have to do this work) feature-request Request for new features to be added type:enhance-existing feature wants to enhance existing monitor

Comments

@ilogus
Copy link

ilogus commented Mar 7, 2024

📑 I have found these related issues/pull requests

After searching through the existing issues and pull requests, I have not found any that directly address the ability to select the version of the HTTP client for HTTP monitors. This feature seems to be unique and has not been discussed or proposed previously.

🏷️ Feature Request Type

Change to existing monitor, Settings

🔖 Feature description

The feature I am proposing is to introduce the ability for users to select the version of the HTTP client used for HTTP monitoring tasks. This would provide additional flexibility and control over monitoring, allowing users to tailor their monitoring more closely to their specific needs and the requirements of the websites or services they are tracking. For instance, being able to choose between HTTP/1.1, HTTP/2, or even HTTP/3 could be crucial for accurately monitoring and diagnosing issues with modern web services that may rely on specific HTTP versions for optimal performance 😄

✔️ Solution

The proposed solution involves adding a dropdown menu or a similar selection mechanism in the HTTP(s) monitor creation and edit screens, enabling users to choose the HTTP version their monitor should use for requests. This selection would then dictate how the monitor performs HTTP requests, ensuring compatibility and providing more detailed monitoring capabilities. It could also include an auto-detect feature that selects the best HTTP version based on the initial handshake with the target server, offering a balance between flexibility and ease of use.

Additionally, it is worth noting that it is currently unclear whether the existing HTTP client library used by Uptime Kuma supports easy switching between different HTTP protocol versions.

❓ Alternatives

No response

📝 Additional Context

No response
@ilogus ilogus added the feature-request Request for new features to be added label Mar 7, 2024
@CommanderStorm CommanderStorm changed the title Support for selecting HTTP client version for HTTP monitors Support for selecting HTTP client version (HTTP/1.0, HTTP/1.1, HTTP/2, HTTP/3) Mar 7, 2024
@CommanderStorm
Copy link
Collaborator

We are using axios under the hood to make network requests.

Given that http2 might be possible with deeper hacks into our requesst library, I am going to keep this issue open (different from #4475)

@CommanderStorm CommanderStorm added area:monitor Everything related to monitors type:enhance-existing feature wants to enhance existing monitor labels Mar 7, 2024
@CommanderStorm CommanderStorm added the blocked-upstream upstream (i.e. a dependency we depend on will have to do this work) label Apr 14, 2024
@mariuszste
Copy link

mariuszste commented May 21, 2024 •
edited
Loading

axios uses node's network stack (XMLHttpRequest).

that is only true when running in a browser, XMLHttpRequest (and as of recently in Axios also fetch) are browser APIs. When running under node it uses the node:http/node:https modules that do not support http2 (hence the missing http2 support issue). Some people made http2 adapters (not sure about the quality of these) and there is a way to use a http2 wrapper that acts like node:http and monkey patch that but that's even more hacky than an adapter.

@strarsis
Copy link

strarsis commented Aug 31, 2024 •
edited
Loading

There is a new monitor type HTTP(s) - Browser Engine (Chrome/Chromium) (Beta), I just noticed. Chrome should already support HTTP/3. So this should allow for testing HTTP/3 and the other connection types that Chrome may select.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:monitor Everything related to monitors blocked-upstream upstream (i.e. a dependency we depend on will have to do this work) feature-request Request for new features to be added type:enhance-existing feature wants to enhance existing monitor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@strarsis @ilogus @CommanderStorm @mariuszste