Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(recurring-job) Modify the interaction mode for force creating sna… #605

Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix(recurring-job) Modify the interaction mode for force creating sna… #605

merged 1 commit into from
Mar 30, 2023

Conversation

smallteeths
Copy link
Contributor

@smallteeths smallteeths commented Mar 28, 2023 •
edited
Loading

longhorn/longhorn#5610

image

wangsiye/longhorn-ui:368fa09

Demo

Jietu20230328-134850-HD

@smallteeths smallteeths requested a review from a team as a code owner March 28, 2023 05:25
@smallteeths smallteeths changed the title [WIP] fix(recurring-job) Modify the interaction mode for force creating sna… fix(recurring-job) Modify the interaction mode for force creating sna… Mar 28, 2023
@innobead
Copy link
Member

innobead commented Mar 28, 2023 •
edited
Loading

@smallteeths can we add a tip for force create for different types?

For snapshot, Create snapshots periodically, even if expired snapshots cannot be cleaned up.
For backup, Create backups periodically, even if expired snapshots cannot be cleaned up.

@mantissahz WDYT?

cc @shuo-wu @c3y1huang @khushboo-rancher

@mantissahz
Copy link
Contributor

For snapshot, Create snapshots periodically, even if expired snapshots cannot be cleaned up.
For backup, Create backups periodically, even if expired snapshots cannot be cleaned up.

That will be great if users could know what's the purpose for the force create

@smallteeths
fix(recurring-job) Modify the interaction mode for force creating sna…
81b3efd 
…pshots and backups

Signed-off-by: Siye Wang <siye@rancher.com>
@smallteeths
Copy link
Contributor Author

@smallteeths can we add a tip for force create for different types?

For snapshot, Create snapshots periodically, even if expired snapshots cannot be cleaned up. For backup, Create backups periodically, even if expired snapshots cannot be cleaned up.

@mantissahz WDYT?

cc @shuo-wu @c3y1huang @khushboo-rancher

done

The longhorn-ui image is update to wangsiye/longhorn-ui:3849cad

Jietu20230328-152931-HD

@mantissahz
Copy link
Contributor

Verified with wangsiye/longhorn-ui:3849cad.

@innobead innobead merged commit 3ddbe5d into longhorn:master Mar 30, 2023
@innobead
Copy link
Member

@Mergifyio backport v1.4.x v1.3.x

@mergify
Copy link

mergify bot commented Mar 30, 2023 •
edited
Loading

backport v1.4.x v1.3.x

✅ Backports have been created

This was referenced Mar 30, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innobead innobead innobead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smallteeths @innobead @mantissahz