fix(backup): ensure volume attached before taking backup #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: longhorn/longhorn6699 Signed-off-by: Jack Lin <jack.lin@suse.com>
james-munson
requested changes
Sep 27, 2023
innobead
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
LGTM.
It would be better to improve VerifyAttachment to ensure the ticket is really satisfied, even though it seems insufficient info to achieve this. (currently, we only have the node ID to attach and the volume status.)
/controller/backup_controller.go#L624-L627
ok, err := bc.VerifyAttachment(backup, volume.Name)
if err != nil {
return nil, err
}
|
@mergify backport v1.5.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: longhorn/longhorn#6699
need to ensure engine status and desired statue are the same before taking backup