Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm Chart: Adds option for volume encryption and setup for volume encryption #9627

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Helm Chart: Adds option for volume encryption and setup for volume encryption #9627

wants to merge 2 commits into from
+53 −0

Conversation

seb-kw
Copy link

@seb-kw seb-kw commented Oct 13, 2024

Which issue(s) this PR fixes:

Issue #

What this PR does / why we need it:

This PR introduces the option to enable volume encryption.

Adds:

  • Volume Encryption: An option to enable encryption at the storage class level, ensuring that all new volumes are encrypted by default.
  • Secret Management: Support for defining custom encryption secrets, with automatic generation of encryption secrets when not provided.
  • Backup of Encryption Secret: Instructions are included for backing up/ extracting the encryption secret.

Special notes for your reviewer:

Additional documentation or context

Longhorns docs.

@seb-kw
Adds option for volume encryption and setup for volume encryption
46c25e3 
Signed-off-by: Sebastian Kawelke <kawelkesebastian@gmail.com>
@seb-kw seb-kw requested a review from a team as a code owner October 13, 2024 10:56
@mergify Mergify
Copy link

mergify bot commented Oct 14, 2024

This pull request is now in conflict. Could you fix it @seb-kw? 🙏

@derekbit
Copy link
Member

cc @mantissahz

@mantissahz
Copy link
Contributor

mantissahz commented Oct 15, 2024 •
edited
Loading

Hi @seb-kw,

Could you fix the conflicts first?

and it's similar with #9007

@seb-kw
Merge branch 'master' into master
7c60de9 
Signed-off-by: Sebastian Kawelke <66557440+seb-kw@users.noreply.github.com>
@seb-kw
Copy link
Author

seb-kw commented Oct 29, 2024

Hi @mantissahz thanks for the response. The conflict should be fixed now.
#9007 looks pretty similar, unfortunately haven't seen it, sry...
It is a bit different in terms of the secret set-up (this PR includes secret generation if none provided by user with a helm-lookup to not overwrite, e.g. during an upgrade).

I would be very happy to combine the efforts — do you have any suggestions on how to proceed here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@seb-kw seb-kw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seb-kw @derekbit @mantissahz