Add LEP for Live Upgrade For Data Engine of V2 Volumes #8814
Conversation
derekbit
force-pushed
the
v2-volume-upgrade-lep
branch
4 times, most recently
from
19d04f5 to
e9ce49e
Compare
derekbit
force-pushed
the
v2-volume-upgrade-lep
branch
from
e9ce49e to
6701dd8
Compare
derekbit
force-pushed
the
v2-volume-upgrade-lep
branch
from
6701dd8 to
f0982df
Compare
|
|
||
| ### Non-goals [optional] | ||
|
|
||
| - Support live upgrades of the data engine for a v2 volume with a single replica. |
There was a problem hiding this comment.
Is there a plan for this case in the next version
There was a problem hiding this comment.
No. It is a hard limit.
enhancements/20240624-live-upgrade-for-data-engine-of-v2-volumes.md
Outdated
Show resolved
Hide resolved
| - Delete the old target for the volume on the upgrading node. | ||
| ``` | ||
| InstanceDeleteTarget() | ||
| |-> EngineDeleteTarget() | ||
| ``` | ||
| - Resume the linear device mapper and continue IO processing. |
There was a problem hiding this comment.
Will Longhorn revert back to the old target if there is something wrong with the temporary target? and due to this case, it's better to resume the dm device IO before deleting the old target.
There was a problem hiding this comment.
due to this case, it's better to resume the dm device IO before deleting the old target.
Yes, but I found the nvme will somehow crash if deleting the old target after resuming IO. I'm still investigating the root cause.
There was a problem hiding this comment.
due to this case, it's better to resume the dm device IO before deleting the old target.
Ideally, yes. But we need to overcome #8814 (comment) first.
| - If the existing instance-manager pod does not have any running engines with targets, the instance-manager and its pod will be deleted by the node controller. | ||
| - Replicas managed by the deleted instance-manager are marked as ERROR, causing any volume with replicas on the upgrading node to become degraded. | ||
| - A new instance-manager is then created and starts running. | ||
| - Switch Over Target Back |
There was a problem hiding this comment.
Similarly, will Longhorn revert to the temporary target if there is something wrong with the new target?
There was a problem hiding this comment.
Same issue for now #8814 (comment)
derekbit
force-pushed
the
v2-volume-upgrade-lep
branch
from
f0982df to
ecd14ad
Compare
Longhorn 6001 Signed-off-by: Derek Su <derek.su@suse.com>
derekbit
force-pushed
the
v2-volume-upgrade-lep
branch
from
ecd14ad to
f06da81
Compare
|
Replaced by #9807 |
Which issue(s) this PR fixes:
Issue #6001
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context