Fix chart labels #6983
Fix chart labels #6983
Conversation
Signed-off-by: Tim Stoop <tim@kumina.nl>
There was a problem hiding this comment.
LGTM.
Some other labels are automaticaly generated for each resource created for a Longhorn instance installation.
ref: /deploy/longhorn.yaml#L4097-L4099
app.kubernetes.io/name: longhorn
app.kubernetes.io/instance: longhorn
app.kubernetes.io/version: v1.6.0-dev
|
@derekbit @PhanLe1010 @shuo-wu any concerns about this change? |
|
longhorn-manager codes need changes as well, e.g. https://github.com/longhorn/longhorn-manager/blob/master/app/post_upgrade.go#L108. |
@timstoop Would you like to contribute this change to longhorn-manager as well? |
|
I'm no Go programmer, so I don't have the local toolset available to actually test this. Happy to make the change, but I have to depend on you to make sure the change actually works! |
|
Yeah, I had a look at that code, but I have no idea what it is doing. In my mind, it's probably changing |
|
We can keep the original label |
|
This pull request is now in conflict. Could you fix it @timstoop? 🙏 |
Switch the
applabel key to the well knownapp.kubernetes.io/componentkey instead. This helps other applications (like cilium hubble) identify the Pods easier. More information about the label can be found here: https://kubernetes.io/docs/reference/labels-annotations-taints/#app-kubernetes-io-componentI've remove the
app:label from the tls-secret, as I felt like it did not serve a purpose and all important labels are already added by the helper script.I was unable to find any reference to this label in the application code (but that said, I'm not very familiar with the application code).
This is a replacement for PR #6974 where I messed up the label key name.