Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lep): multiple backup stores support #6630

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(lep): multiple backup stores support #6630

wants to merge 1 commit into from
+509 −0

Conversation

mantissahz
Copy link
Contributor

Ref: #5411

@mantissahz mantissahz requested a review from innobead September 4, 2023 06:37
@mantissahz mantissahz self-assigned this Sep 4, 2023
@mantissahz mantissahz requested a review from a team as a code owner September 4, 2023 06:37
@mantissahz mantissahz requested review from derekbit and a team September 5, 2023 06:03
james-munson
james-munson requested changes Sep 5, 2023
View reviewed changes
enhancements/20230828-multiple-backup-stores-support.md Outdated Show resolved Hide resolved
enhancements/20230828-multiple-backup-stores-support.md Outdated Show resolved Hide resolved
enhancements/20230828-multiple-backup-stores-support.md Outdated Show resolved Hide resolved
enhancements/20230828-multiple-backup-stores-support.md Outdated Show resolved Hide resolved
enhancements/20230828-multiple-backup-stores-support.md Outdated Show resolved Hide resolved
enhancements/20230828-multiple-backup-stores-support.md Outdated Show resolved Hide resolved
enhancements/20230828-multiple-backup-stores-support.md Outdated Show resolved Hide resolved
enhancements/20230828-multiple-backup-stores-support.md Outdated Show resolved Hide resolved
enhancements/20230828-multiple-backup-stores-support.md Outdated Show resolved Hide resolved
@mantissahz mantissahz force-pushed the issue5411 branch 2 times, most recently from 77da472 to 8ea4019 Compare September 6, 2023 02:06
@mantissahz mantissahz requested review from james-munson and a team September 6, 2023 02:06
james-munson
james-munson previously approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@james-munson james-munson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. LGTM

@mantissahz mantissahz requested a review from a team September 26, 2023 07:59
@mantissahz mantissahz force-pushed the issue5411 branch 2 times, most recently from 8770243 to edc8269 Compare September 28, 2023 08:13
innobead
innobead requested changes Dec 16, 2024
View reviewed changes
Copy link
Member

@innobead innobead left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, the design is quite straightforward.

However, I still have some feedback and some points need to be clarified and explained briefly.

Also, @derekbit mentioned several important items that needed to be fixed. Please work on that. Thanks.

enhancements/20240926-multiple-backup-targets-support.md Outdated Show resolved Hide resolved
enhancements/20240926-multiple-backup-targets-support.md Show resolved Hide resolved
enhancements/20240926-multiple-backup-targets-support.md Outdated Show resolved Hide resolved
enhancements/20240926-multiple-backup-targets-support.md Outdated Show resolved Hide resolved
enhancements/20240926-multiple-backup-targets-support.md Show resolved Hide resolved
enhancements/20240926-multiple-backup-targets-support.md Show resolved Hide resolved
enhancements/20240926-multiple-backup-targets-support.md Show resolved Hide resolved
enhancements/20240926-multiple-backup-targets-support.md Outdated Show resolved Hide resolved
enhancements/20240926-multiple-backup-targets-support.md Outdated Show resolved Hide resolved
enhancements/20240926-multiple-backup-targets-support.md Show resolved Hide resolved
@mantissahz mantissahz force-pushed the issue5411 branch 2 times, most recently from c1b423e to 8b35b5c Compare December 16, 2024 10:53
@mantissahz mantissahz force-pushed the issue5411 branch 3 times, most recently from 0b30bca to 7f897ee Compare December 16, 2024 11:18
@mantissahz mantissahz requested a review from c3y1huang December 17, 2024 03:39
@mantissahz mantissahz force-pushed the issue5411 branch 5 times, most recently from f712028 to 6fe1b1d Compare December 30, 2024 17:03
@mantissahz
feat(lep): multiple backup stores support
05aee75 
ref: longhorn/longhorn 5411

Signed-off-by: James Lu <james.lu@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhanLe1010 PhanLe1010 Awaiting requested review from PhanLe1010

@a110605 a110605 Awaiting requested review from a110605

@shuo-wu shuo-wu Awaiting requested review from shuo-wu

@james-munson james-munson Awaiting requested review from james-munson

@ChanYiLin ChanYiLin Awaiting requested review from ChanYiLin

@derekbit derekbit Awaiting requested review from derekbit

@innobead innobead Awaiting requested review from innobead

@c3y1huang c3y1huang Awaiting requested review from c3y1huang

@roger-ryao roger-ryao Awaiting requested review from roger-ryao

Requested changes must be addressed to merge this pull request.

Assignees

@mantissahz mantissahz

Labels
None yet
Projects
Longhorn Sprint
Status: New Issues
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mantissahz @derekbit @innobead @a110605 @ChanYiLin @PhanLe1010 @c3y1huang @shuo-wu @james-munson @roger-ryao