Fix timeout caused by dead mount points #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetMnt() iterates and gets information of all mount points in the mount table. If there is any dead mount point, the iteration will hang for a while, so the caller (backup ls) will run into a timeout error in the end. Longhorn 5856 Signed-off-by: Derek Su <derek.su@suse.com>
The cleanup leads to the mount timeout if there is any dead mount point. Longhorn 5856 Signed-off-by: Derek Su <derek.su@suse.com>
Longhorn 5856 Signed-off-by: Derek Su <derek.su@suse.com>
derekbit
commented
May 4, 2023
Comment on lines
+52
to
+62
| func fstypeToKind(fstype int64) (string, error) { | ||
| switch fstype { | ||
| case unix.NFS_SUPER_MAGIC: | ||
| return "nfs", nil | ||
| case unix.CIFS_SUPER_MAGIC: | ||
| return "cifs", nil | ||
| default: | ||
| return "", fmt.Errorf("unknown fstype %v", fstype) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Remove case unix.CIFS_SUPER_MAGIC: for v1.4.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
longhorn/longhorn#5856