Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process::extract_without_order must avoid re-invoking processor methods #6

Open
seanpianka opened this issue Sep 16, 2020 · 4 comments
Open

process::extract_without_order must avoid re-invoking processor methods #6

seanpianka opened this issue Sep 16, 2020 · 4 comments
Assignees
@seanpianka
Labels
bug conformance related to matching fuzzywuzzy performance
Milestone
1.0

Comments

@seanpianka
Copy link
Collaborator

See the original implementation where the processor function is only executed once if it's a known method.

I'm not sure if this is an optimization to prevent duplicate calls, or if multiple invocations could lead to some undesired state? i.e. the processor function is not idempotent.
@seanpianka seanpianka mentioned this issue Sep 16, 2020
Merged
@seanpianka seanpianka mentioned this issue Nov 2, 2020
Open
@seanpianka seanpianka self-assigned this Nov 2, 2020
@seanpianka seanpianka added the 1.0.0 Road to 1.0.0 label Nov 2, 2020
@seanpianka seanpianka removed the 1.0.0 Road to 1.0.0 label Nov 4, 2020
@seanpianka seanpianka added conformance related to matching fuzzywuzzy bug performance labels Jan 9, 2021
@logannc
Copy link
Owner

logannc commented Mar 27, 2021

wratio -> wratio and wratio_calc like ratio_full and simple_calc

same with partial_ratio_full for that matter

@logannc logannc mentioned this issue Mar 27, 2021
Open
@logannc
Copy link
Owner

logannc commented Mar 27, 2021

basically the current impl of extract_without_order doesn't double call the processors, but if the scorer calls processing, you're hosed. It just so happens the original scorers by default do because we havent split them out as concepts.

@seanpianka
Copy link
Collaborator Author

Does #28 split them out as concepts?

@logannc
Copy link
Owner

logannc commented Mar 28, 2021

not quite, no. You have things like ratio_full which does processor and delegates to simple_ratio which could be considered a scorer, but that structure is not applied to, say, partial_ratio_full which would need to split out most of its body into a best_partial_ratio or something.

@seanpianka seanpianka added this to the 1.0 milestone May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanpianka seanpianka

Labels
bug conformance related to matching fuzzywuzzy performance
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@logannc @seanpianka