Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add an environment variable to disable telemetry globally #1520

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

folliehiyuki
Copy link
Contributor

@folliehiyuki folliehiyuki commented Jan 6, 2025

With the current model described at https://devpod.sh/docs/other-topics/telemetry#telemetry-opt-out-process, a CLI user wanting to opt out of telemetry completely needs to remember to set the TELEMTRY option for every new context.

This PR adds an additional environment variable as a method to disable telemetry regardless of the current context. This is a common approach among open-sourced CLI programs.

@pascalbreuninger
Copy link
Member

@folliehiyuki thanks for your contribution.
Fair enough, could you also update the docs please?

@folliehiyuki folliehiyuki force-pushed the telemetry-global-var branch 2 times, most recently from 4cf7750 to 1aeea44 Compare January 8, 2025 13:01
@folliehiyuki
Copy link
Contributor Author

I've updated the telemetry docs page. My editor spotted 2 spelling errors in the file, so I added another commit fixing those as well, if you don't mind.

Copy link
Member

@pascalbreuninger pascalbreuninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascalbreuninger pascalbreuninger merged commit dd3c94d into loft-sh:main Jan 8, 2025
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants