Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: partially fix broken tests #5733

Merged
merged 22 commits into from
Sep 21, 2023
Merged

test: partially fix broken tests #5733

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
87b8cfe
test: fix throttle.spec.js
tisonkun Sep 21, 2023
b5d13e5
test: fix pickBy.spec.js
tisonkun Sep 21, 2023
f267b51
test: fix isBuffer.spec.js
tisonkun Sep 21, 2023
838bcc4
test: partially fix attempt.spec.js
tisonkun Sep 21, 2023
eb70fdf
test: partially fix dropRightWhile.spec.js
tisonkun Sep 21, 2023
161cc5a
test: fix defer.spec.js and rest.spec.js
tisonkun Sep 21, 2023
fd9c066
test: fix invoke.spec.js
tisonkun Sep 21, 2023
a5ee6fd
test: fix isArray.spec.js
tisonkun Sep 21, 2023
55bea24
test: partially fix iteration-methods.spec.js
tisonkun Sep 21, 2023
06561c2
test: fix xor-methods.spec.js
tisonkun Sep 21, 2023
afe9adf
test: fix property.spec.js
tisonkun Sep 21, 2023
30060af
test: fix ary.spec.js
tisonkun Sep 21, 2023
2a8bedc
test: fix omit-methods.spec.js
tisonkun Sep 21, 2023
698443d
test: fix debounce-and-throttle.spec.js
tisonkun Sep 21, 2023
24458d7
test: fix unzip-and-zip.spec.js
tisonkun Sep 21, 2023
9b6d7d9
test: fix toPairs-methods.spec.js
tisonkun Sep 21, 2023
057213e
test: fix exit-early.spec.js
tisonkun Sep 21, 2023
4cd836a
test: temporarily comment out takeWhile and dropWhile tests
tisonkun Sep 21, 2023
a4716ae
test: partially fix union*.spec.js
tisonkun Sep 21, 2023
d937ecc
test: fix startsWith-and-endsWith.spec.js
tisonkun Sep 21, 2023
58a7378
test: fix isNil.spec.js
tisonkun Sep 21, 2023
35330b7
test: fix some of syntax errors
tisonkun Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix invoke.spec.js 
Signed-off-by: tison <wander4096@gmail.com>
  • Loading branch information
@tisonkun
tisonkun committed Sep 21, 2023
commit fd9c066e3988e7707316662f8890ea49338ffedc
32 changes: 17 additions & 15 deletions test/invoke.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ describe('invoke', () => {
return [a, b];
},
};
const actual = invoke(object, 'a', 1, 2);
const actual = invoke(object, 'a', [1, 2]);

expect(actual, [1).toEqual(2]);
expect(actual).toEqual([1, 2]);
});

it('should not error on nullish elements', () => {
Expand All @@ -27,7 +27,7 @@ describe('invoke', () => {

const actual = lodashStable.map(values, (value) => {
try {
return invoke(value, 'a.b', 1, 2);
return invoke(value, 'a.b', [1, 2]);
} catch (e) {}
});

Expand All @@ -40,7 +40,7 @@ describe('invoke', () => {

const actual = lodashStable.map(props, (key) => invoke(object, key));

expect(actual, ['a', 'a', 'b').toEqual('b']);
expect(actual).toEqual(['a', 'a', 'b', 'b']);
});

it('should support deep paths', () => {
Expand All @@ -53,8 +53,8 @@ describe('invoke', () => {
};

lodashStable.each(['a.b', ['a', 'b']], (path) => {
const actual = invoke(object, path, 1, 2);
expect(actual, [1).toEqual(2]);
const actual = invoke(object, path, [1, 2]);
expect(actual).toEqual([1, 2]);
});
});

Expand All @@ -73,13 +73,15 @@ describe('invoke', () => {
});
});

it('should return an unwrapped value when implicitly chaining', () => {
const object = { a: stubOne };
expect(_(object).invoke('a')).toBe(1);
});

it('should return a wrapped value when explicitly chaining', () => {
const object = { a: stubOne };
expect(_(object).chain().invoke('a') instanceof _)
});
// FIXME: Work out a solution for _.
//
// it('should return an unwrapped value when implicitly chaining', () => {
// const object = { a: stubOne };
// expect(_(object).invoke('a')).toBe(1);
// });
//
// it('should return a wrapped value when explicitly chaining', () => {
// const object = { a: stubOne };
// expect(_(object).chain().invoke('a') instanceof _)
// });
});