Add cop to standardrb to enforce Mod::ModeratorController #1393 #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All controllers in the `app/controllers/mod/` directory should inherit from `Mod::ModeratorController`
|
Sorry this took me a minute to get to, I was sick and then traveling for the holiday. This is a totally clear implementation, I’m really happy to merge it so I don’t footgun myself by creating a controller that doesn’t inherit from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All controllers in the
app/controllers/mod/directory should inherit fromMod::ModeratorControllerresolves #1393
Note:
The cops are located in the
.lib/custom_cops/directory, which I've added to the ignore list ofconfig.autolod_libs. If my understanding of config.autoload_libs(ignore:) is correct, this should prevent this directory from being loaded when the application runs (in any environment).If your editor is configured with standardrb integration, the code in
.lib/custom_cops/will load and will run for ruby files in theapp/controllers/mod/directory.