Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding a merged submission does not remove all comments from that discussion from users comment feed #1298

Open
gustafe opened this issue Aug 6, 2024 · 1 comment
Labels

Comments

@gustafe
Copy link

gustafe commented Aug 6, 2024

When clicking "hide" on a submission with merged entries, not all comments from that submission are removed from my comment feed.

Example, right now (2024-08-06 23:03 CEST) this submission is on the front page:

https://lobste.rs/s/imgdoi/keygen_is_now_fair_source

The submission "Keygen is now Fair Source" is the primary, while "Fair source" is merged.

In my comment feed, the following comments are present:

  • on "Keygen is now Fair Source": 12
  • on "Fair source": 6
  • on other submissions: 20-(6+12)=2

If I select "hide" on the submission above, the ratio changes:

  • on "Fair source": 12
  • on other submissions: 20-12=8

Expected behavior: after selecting "hide", no comments in the feed should be associated with "Fair source" or "Keygen is now Fair Source"

Platform: Firefox on macOs.

@pushcx pushcx added the bug label Aug 6, 2024
@pushcx
Copy link
Member

pushcx commented Aug 6, 2024

There have been many bugs because of how the database models merged stories and this is probably going to be the one that forces a remodel. We should separate out a Story (thing that appears on homepage with title) and a ______ with link and/or text. Most stories will have exactly one, but merged will have multiple.

Blosterhxh pushed a commit to Ryzen114/lobsters that referenced this issue Nov 30, 2024
Ryzen114 added a commit to Ryzen114/lobsters that referenced this issue Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants