Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ refactor: Remove proxy url settings for NextAuth #4826

Merged
merged 4 commits into from
Dec 7, 2024

Conversation

cy948
Copy link
Contributor

@cy948 cy948 commented Nov 28, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

  • src/libs/next-auth/auth.config.ts:
    • 移除通过 APP_URL 设定 redirectProxyUrl
    • 增加打印日志的选项,可通过环境变量 NEXT_AUTH_DEBUG

📝 补充信息 | Additional Information

Copy link

vercel bot commented Nov 28, 2024

@cy948 is attempting to deploy a commit to the LobeChat Community Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 28, 2024
@lobehubbot
Copy link
Member

👍 @cy948

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@cy948 cy948 marked this pull request as draft November 28, 2024 11:14
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.62%. Comparing base (f900c0a) to head (644f19d).
Report is 65 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4826      +/-   ##
==========================================
+ Coverage   91.53%   91.62%   +0.08%     
==========================================
  Files         538      538              
  Lines       37818    38202     +384     
  Branches     3500     3509       +9     
==========================================
+ Hits        34618    35001     +383     
- Misses       3200     3201       +1     
Flag Coverage Δ
app 91.62% <100.00%> (+0.08%) ⬆️
server 96.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cy948 cy948 marked this pull request as ready for review November 28, 2024 11:18
@arvinxx
Copy link
Contributor

arvinxx commented Nov 28, 2024

这个去掉就能解决之前很多报错问题了吗?

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Will removing this solve many of the previous error problems?

@cy948
Copy link
Contributor Author

cy948 commented Nov 28, 2024

这个去掉就能解决之前很多报错问题了吗?

是指哪个报错的issue呢? 这个去掉之后就不会弹redundant url 的 warning。

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Will removing this solve many previous error problems?

Which issue does the error report refer to? After removing this, the redundant url warning will no longer appear.

Copy link

vercel bot commented Dec 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-database ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2024 9:01am

@arvinxx
Copy link
Contributor

arvinxx commented Dec 1, 2024

@cy948 构建报错,eslint 跑一下

./src/libs/next-auth/auth.config.ts
45:3 Error: Expected object keys to be in ascending order. 'debug' should be before 'trustHost'. sort-keys-fix/sort-keys-fix

@cy948
Copy link
Contributor Author

cy948 commented Dec 1, 2024

@cy948 构建报错,eslint 跑一下

./src/libs/next-auth/auth.config.ts 45:3 Error: Expected object keys to be in ascending order. 'debug' should be before 'trustHost'. sort-keys-fix/sort-keys-fix

👌

@arvinxx arvinxx merged commit a502c17 into lobehub:main Dec 7, 2024
7 of 8 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @cy948 ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Dec 7, 2024
### [Version&nbsp;1.36.1](v1.36.0...v1.36.1)
<sup>Released on **2024-12-07**</sup>

#### ♻ Code Refactoring

- **misc**: Remove proxy url settings for NextAuth.

#### 💄 Styles

- **misc**: Add gemini-exp-1206 model.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Remove proxy url settings for NextAuth, closes [#4826](#4826) ([a502c17](a502c17))

#### Styles

* **misc**: Add gemini-exp-1206 model, closes [#4909](#4909) ([9ff2c03](9ff2c03))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.36.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Dec 7, 2024
### [Version&nbsp;1.78.1](v1.78.0...v1.78.1)
<sup>Released on **2024-12-07**</sup>

#### ♻ Code Refactoring

- **misc**: Refactor async params route to adapt next15 breaking change, Remove proxy url settings for NextAuth.

#### 💄 Styles

- **misc**: Add gemini-exp-1206 model.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Refactor async params route to adapt next15 breaking change, closes [lobehub#4905](https://github.com/bentwnghk/lobe-chat/issues/4905) ([5d61950](5d61950))
* **misc**: Remove proxy url settings for NextAuth, closes [lobehub#4826](https://github.com/bentwnghk/lobe-chat/issues/4826) ([a502c17](a502c17))

#### Styles

* **misc**: Add gemini-exp-1206 model, closes [lobehub#4909](https://github.com/bentwnghk/lobe-chat/issues/4909) ([9ff2c03](9ff2c03))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants