Update PULL_REQUEST_TEMPLATE.md

lo-fo · Dec 6, 2018 · 44cb0ad · 44cb0ad
1 parent c37b890
commit 44cb0ad
Showing 1 changed file with 18 additions and 11 deletions.
diff --git a/system/PULL_REQUEST_TEMPLATE.md b/system/PULL_REQUEST_TEMPLATE.md
@@ -1,17 +1,24 @@
-### Pull Request check-list
+<!--
+Thank you for your pull request. Please provide a description above and review
+the requirements below.
 
-_Please make sure to review and check all of these items:_
+Bug fixes and new features should include tests and possibly benchmarks.
 
-- [ ] Does UNIX or Windows pass with
-  this change (including linting)?
-- [ ] Is the commit message formatted according to CONTRIBUTING.md?
-- [ ] If this change fixes a bug (or a performance problem), is a regression
-  test (or a benchmark) included?
-- [ ] Is a documentation update included (if this change modifies
-  existing APIs, or introduces new ones)?
+Contributors guide: ./CONTRIBUTING.md
+-->
 
-_NOTE: these things are not required to open a PR and can be done
-afterwards / while the PR is open._
+<!-- _Please make sure to review and check all of these items:_ -->
+
+
+##### Checklist
+<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
+
+- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes
+- [ ] tests and/or benchmarks are included
+- [ ] documentation is changed or added
+- [ ] commit message follows [commit guidelines](./doc/guides/contributing/pull-requests.md#commit-message-guidelines)
+
+<!-- _NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open._ -->
 
 ### Affected core subsystem(s)
 <!-- Please provide affected core subsystem(s). -->