Merge pull request prometheus#1828 from drawks/iss-1821

Error on non-flag commandline arguments
lmars · Jul 20, 2016 · 08891be · 08891be
2 parents 12709af + 00ea36c
commit 08891be
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/cmd/prometheus/config.go b/cmd/prometheus/config.go
@@ -245,10 +245,13 @@ func init() {
 
 func parse(args []string) error {
 	err := cfg.fs.Parse(args)
-	if err != nil {
+	if err != nil || len(cfg.fs.Args()) != 0 {
 		if err != flag.ErrHelp {
 			log.Errorf("Invalid command line arguments. Help: %s -h", os.Args[0])
 		}
+		if err == nil {
+			err = fmt.Errorf("Non-flag argument on command line: %q", cfg.fs.Args()[0])
+		}
 		return err
 	}