Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider changing EventListenable.collect to return Nothing #457

Closed
weefbellington opened this issue Jul 16, 2024 · 1 comment · Fixed by #458
Closed

consider changing EventListenable.collect to return Nothing #457

weefbellington opened this issue Jul 16, 2024 · 1 comment · Fixed by #458

Comments

@weefbellington
Copy link

SharedFlow.collect function specifies Nothing as its return type. This is helpful for preventing errors, since the linter can mark any code after collect as unreachable.

Consider changing the EventListenable.collect extension function to match.

See also this issue: Kotlin/kotlinx.coroutines#2789
@davidliu
Copy link
Contributor

Thanks for the heads up! Will do.

@davidliu davidliu mentioned this issue Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Have EventListenable.collect return Nothing livekit/client-sdk-android
2 participants
@davidliu @weefbellington