Skip to content

Commit

Permalink
Fix admission metrics to use bucket sizes matching metric unit
Browse files Browse the repository at this point in the history
  • Loading branch information
jpbetz committed Jun 5, 2019
1 parent 88f8c78 commit 084c525
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions staging/src/k8s.io/apiserver/pkg/admission/metrics/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ const (
)

var (
// Use buckets ranging from 25 ms to ~2.5 seconds.
latencyBuckets = prometheus.ExponentialBuckets(25000, 2.5, 5)
// Use buckets ranging from 5 ms to 2.5 seconds (admission webhooks timeout at 30 seconds by default).
latencyBuckets = []float64{0.005, 0.025, 0.1, 0.5, 2.5}
latencySummaryMaxAge = 5 * time.Hour

// Metrics provides access to all admission metrics.
Expand Down

0 comments on commit 084c525

Please sign in to comment.