Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move dependency resolving into src meson #1937

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

move dependency resolving into src meson #1937

wants to merge 1 commit into from

Conversation

Jan200101
Copy link
Contributor

These are only needed for building the actual project and not for managing resources or setting various flags. Gets rid of the double source-only check and moves it closer to the consumer

@Jan200101
move dependency resolving into source file
7812f64 
These are only needed for building the actual project and not for managing resources or setting various flags.
Gets rid of the double `source-only` check and moves it closer to the consumer
@Jan200101 Jan200101 changed the title move dependency resolving into source file move dependency resolving into src meson Nov 10, 2024
@Jan200101 Jan200101 marked this pull request as ready for review November 10, 2024 14:23
takase1121
takase1121 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@takase1121 takase1121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no strong feelings about this change, but I think it can make finding where the deps were declared more confusing. At the same time, having lite_link_args appearing out of thin air in src/meson.build is also weird. I guess it balances out.

Guldoman
Guldoman approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@Guldoman Guldoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinions about this either.
How do other projects organize their meson files?

@Jan200101
Copy link
Contributor Author

qemu does it anywhere it wants to
plymouth only has it in the main meson.build but also makes sure anything consumed by a subdirectory meson.build is prepared ahead of time

there is also an alternative to what was proposed here:
moving all the heavy logic (mainly dirmonitor code) out of src/meson.build into meson.build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takase1121 takase1121 takase1121 approved these changes

@Guldoman Guldoman Guldoman approved these changes

Assignees
No one assigned
Labels
Category: Build System Category: C Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jan200101 @Guldoman @takase1121