Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle lpm with lite-xl #1936

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Bundle lpm with lite-xl #1936

wants to merge 1 commit into from

Conversation

Jan200101
Copy link
Contributor

@Jan200101
Copy link
Contributor Author

needs lite-xl/lite-xl-plugin-manager#138

takase1121
takase1121 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@takase1121 takase1121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been a long time coming.

takase1121
takase1121 requested changes Nov 13, 2024
View reviewed changes
Copy link
Member

@takase1121 takase1121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to fix the MSYS CI. Looks like git wasn't installed.

@adamharrison
Copy link
Member

Shouldn't we bundle welcome instead, if we're gonna move this out of CI?

@Jan200101
Copy link
Contributor Author

You might want to fix the MSYS CI. Looks like git wasn't installed.

I intend to go one further and turn make the wrap use the same archive based logic as the other wraps once a new lpm release is tagged

Shouldn't we bundle welcome instead, if we're gonna move this out of CI?

bundle as in include it directly in lite-xl?

Unsure, if its part of lpm we don't need to deal with it ourselves, especially not when lpm is explicitly disabled.

@Guldoman
Copy link
Member

Shouldn't we bundle welcome instead, if we're gonna move this out of CI?

bundle as in include it directly in lite-xl?

The addons release is completely replaced by the welcome plugin, which basically asks the user if they want to install the plugins of the addons release (which will be pulled in by lpm), or if they want to continue with the base install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takase1121 takase1121 takase1121 requested changes

Assignees
No one assigned
Labels
Category: Build System Category: C Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jan200101 @adamharrison @Guldoman @takase1121