implement POSIX polling dirmonitor #1926
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guldoman
reviewed
Nov 2, 2024
Guldoman
reviewed
Nov 2, 2024
Jan200101
force-pushed
the
PR/polling-dirmonitor
branch
from
125fcdc to
319e9d7
Compare
Jan200101
commented
Nov 3, 2024
src/api/dirmonitor/polling.c
Outdated
| } | ||
|
|
||
| int translate_changes_dirmonitor(struct dirmonitor_internal* monitor, char* buffer, int count, int (*change_callback)(int, const char*, void*), void* data) { | ||
| printf("TRANSLATE %i\n", count); |
|
Done some digging around and apparently fstat is bugged on Darwin, would need someone to verify this so the backend will never be selected on MacOS |
Jan200101
commented
Nov 6, 2024
takase1121
reviewed
Nov 14, 2024
Jan200101
commented
Nov 14, 2024
Jan200101
force-pushed
the
PR/polling-dirmonitor
branch
from
b504878 to
530908e
Compare
takase1121
approved these changes
Nov 15, 2024
Guldoman
reviewed
Dec 16, 2024
Comment on lines
+48
to
+50
| for (size_t i = 0; i < monitor->fd_count; ++i) { | ||
| if (monitor->fds[i].fd < 0) | ||
| continue; |
There was a problem hiding this comment.
Could fd_count be raced over?
Same with the fds structs.
For example:
- We enter
get_changes_dirmonitor - Main thread enters
add_dirmonitor add_dirmonitorneeds to allocate new space, so it does, but still doesn't switch it outget_changes_dirmonitorsavesfdsin a registeradd_dirmonitorswitches out the spaces, frees the oldfdsget_changes_dirmonitoruses thefdsfrom the register, SIGSEGVs.
| // Prepare a new list before switching it to prevent race conditions | ||
| struct file_info* old_fds = monitor->fds; | ||
| struct file_info* new_fds; | ||
| new_fds = malloc(sizeof(*new_fds) * (monitor->fd_count + 1)); |
There was a problem hiding this comment.
Still not too sure about just allocating one more space.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin
generic fallback for any POSIX.1-2008 compatible system (though by checking preprocessors it can be lowered down by about a decade)
How it works:
From some minimal testing this seems to work pretty well