renderer: pass errors via SDL_SetError #1919
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a thing that everyone wants but it keeps delayed for no good reason.
This PR adds error messages by using SDL_GetError(). There are a few ways that we can pass error codes around the renderer:
Obviously, this PR uses approach 3. Finally we can get stuff like this:
Obviously that message is kinda long, but this beats not having a proper error message AT ALL.
As a side note, this also implicitly implies that we should adopt a 0 for success and negative for failure convention, as used by SDL. I don't think this is much problem, since we partially use 0 for success already in various places in the codebase.
Closes #1721.