system: emit runtime error when luaL_Stream is unavailable #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guldoman
approved these changes
Oct 25, 2024
Co-authored-by: Guldoman <giulio.lettieri@gmail.com>
takase1121
changed the title
Guldoman
reviewed
Oct 25, 2024
Guldoman
reviewed
Oct 25, 2024
src/api/system.c
Outdated
| // but it is not standardized. YMMV. | ||
| #error luaL_Stream is not supported in this version of Lua. | ||
| #endif | ||
| #ifdef LUA_FILEHANDLE |
There was a problem hiding this comment.
I wonder if you could do an early exit with #ifndef, without an #else block.
Would that raise unreachable code warnings?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns the hard compilation error into an runtime error, when luaL_Stream is not available. I'm not sure if this is the way to go.