Rearrange Plugin Loading and SDL Initialization #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugin, removed project limit, removed the concept of a project maintaining an ordered list of files, and allowed treeview to see things like hidden files and files not actually in the project. Normalizing things, fixed typo. Abstracted root project, and made things more in line with current master behaviour. Removed unused legacy code, as well as ensured that we use absolute paths. Fixed issue with backslahes on linux, will look at windows at some point. Removed stray print. Removed orphaned function. Removed extraneous command. Fixed the ability to close project folders. Removed superceded function. Applied jgm's suggestions.
adamharrison
force-pushed
the
PR/move-sdl-to-lua
branch
from
7670760 to
d0af489
Compare
adamharrison
force-pushed
the
PR/move-sdl-to-lua
branch
from
266d4f1 to
d188f4b
Compare
…et has_restarted.
…ion warnings for legacy interface.
adamharrison
force-pushed
the
PR/move-sdl-to-lua
branch
from
238c3b2 to
1052f25
Compare
adamharrison
force-pushed
the
PR/move-sdl-to-lua
branch
from
1052f25 to
18382f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should only be merged after #1455, as this is rebased off of that.
This demotes project and user modules to be the same as every other type of plugin, just inserted slightly differently. It also allows plugins to modify the plugin load order, and insert additional plugins to be loaded; allowing much easier versions of stuff like https://github.com/adamharrison/lite-xl-foreign where custom loaders can load additional plugins in other languages.
I've also taken the liberty of adding a plugin to force a restart on change of project; as project modules stomping on each other is basically a bug currently. Ditto the user module. This now allows you to easily customize this behavior, and removes the weird kinda stomping from the core.
We could theoretically re-add the stomping as a config option for the plugin, but given how problematic it's been, it's probably not the best idea.