Fix treeview focusing to hidden view #1799
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets visibility to true when treeview:toggle-focus is executed. (Prevents focusing on nonvisible treeview in the editor) Added option to disable this behaviour. (show_on_focus)
|
Sorry. I made a syntax error. |
Guldoman
reviewed
Jun 1, 2024
There was a problem hiding this comment.
Looks good!
I wonder if we should avoid adding the config option, as the behavior of just showing the Treeview sounds sane enough.
Also, I wonder how it would feel if we hide it again (if it was hidden before) when it loses focus. So:
- Treeview is hidden
- treeview:toggle-focus
- Treeview appears
- User opens a file
- Treeview hides again
or
- Treeview is hidden
- treeview:toggle-focus
- Treeview appears
- treeview:toggle-focus
- Treeview hides again
or
- Treeview is hidden
- treeview:toggle-focus
- Treeview appears
- User clicks away from the Treeview
- Treeview hides again
|
Yeah. That would be nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets visibility to true when treeview:toggle-focus is executed. (Prevents focusing on nonvisible treeview in the editor)
Added option to disable this behaviour. (show_on_focus)