Add autocomplete styles #1425
Open
Add autocomplete styles #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add style properties specific to autocomplete.
```lua
style.completion_background = { common.color "#ede7db" }
style.completion_text = { common.color "#000000" }
style.completion_type = { common.color "#4a3a8a" }
style.completion_text_active = { common.color "#8a290f" }
style.completion_infobar_divider = { common.color "#a60000" }
style.completion_infobar_background = { common.color "#fbf7f0" }
style.completion_text_accent = { common.color "#000000" }
```
Might be useful for others.
|
Hey, sorry it took so long to review this. So we had a bit discussion in PR committee meeting number 8 about this; and we came to the conclusion that while we do wanna be able to add more colors like this, especially for plugins. Currenlty the mechanism to do this is just generally to put things in Doing it in style like this, and having fallbacks causes problems with themes that aren't the default theme, because you'll never fallback (i.e., you'll always use the default theme values for these), due to the way the style stuff is inherited. We'll put our a PR to address this with a new system of some kind, sometime soon; we can adjust this PR at that point to use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add style properties specific to autocomplete.
Might be useful for others.