Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[all] Cleanup some old comments #4780

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[all] Cleanup some old comments #4780

wants to merge 1 commit into from

Conversation

justinfagnani
Copy link
Collaborator

Closes #4702

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2024

⚠️ No Changeset found

Latest commit: fa03611

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

nop-update

  • this-change, tip-of-tree, previous-release: unsure 🔍 -8% - +11% (-1.00ms - +1.39ms)
    this-change vs tip-of-tree

render

  • this-change: 48.52ms - 60.76ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -3% - +5% (-0.54ms - +1.05ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +1% (-1.55ms - +0.49ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -38% - +6% (-27.35ms - +5.69ms)
    this-change vs tip-of-tree

update

  • this-change: 534.89ms - 542.58ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -4% - +5% (-1.67ms - +1.88ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -2% - +3% (-1.34ms - +2.10ms)
    this-change vs tip-of-tree
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-6.29ms - +7.12ms)
    this-change vs tip-of-tree

update-reflect

  • this-change: 536.10ms - 543.92ms
  • this-change, tip-of-tree, previous-release: unsure 🔍 -1% - +1% (-4.73ms - +5.25ms)
    this-change vs tip-of-tree

Results

this-change

render

VersionAvg timevs
48.52ms - 60.76ms-

update

VersionAvg timevs
534.89ms - 542.58ms-

update-reflect

VersionAvg timevs
536.10ms - 543.92ms-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
20.26ms - 21.04ms-unsure 🔍
-3% - +5%
-0.54ms - +1.05ms		unsure 🔍
-1% - +4%
-0.23ms - +0.84ms
tip-of-tree
tip-of-tree		19.71ms - 21.08msunsure 🔍
-5% - +3%
-1.05ms - +0.54ms		-unsure 🔍
-4% - +4%
-0.73ms - +0.83ms
previous-release
previous-release		19.98ms - 20.71msunsure 🔍
-4% - +1%
-0.84ms - +0.23ms		unsure 🔍
-4% - +4%
-0.83ms - +0.73ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
39.82ms - 42.29ms-unsure 🔍
-4% - +5%
-1.67ms - +1.88ms		unsure 🔍
-4% - +4%
-1.78ms - +1.79ms
tip-of-tree
tip-of-tree		39.68ms - 42.23msunsure 🔍
-5% - +4%
-1.88ms - +1.67ms		-unsure 🔍
-5% - +4%
-1.91ms - +1.71ms
previous-release
previous-release		39.76ms - 42.34msunsure 🔍
-4% - +4%
-1.79ms - +1.78ms		unsure 🔍
-4% - +5%
-1.71ms - +1.91ms		-

nop-update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
12.58ms - 14.25ms-unsure 🔍
-8% - +11%
-1.00ms - +1.39ms		unsure 🔍
-2% - +16%
-0.25ms - +1.93ms
tip-of-tree
tip-of-tree		12.37ms - 14.07msunsure 🔍
-10% - +7%
-1.39ms - +1.00ms		-unsure 🔍
-4% - +14%
-0.45ms - +1.74ms
previous-release
previous-release		11.88ms - 13.27msunsure 🔍
-14% - +2%
-1.93ms - +0.25ms		unsure 🔍
-13% - +3%
-1.74ms - +0.45ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
36.80ms - 37.52ms-unsure 🔍
-4% - +1%
-1.55ms - +0.49ms		unsure 🔍
-2% - +1%
-0.78ms - +0.31ms
tip-of-tree
tip-of-tree		36.74ms - 38.64msunsure 🔍
-1% - +4%
-0.49ms - +1.55ms		-unsure 🔍
-2% - +4%
-0.74ms - +1.33ms
previous-release
previous-release		36.99ms - 37.80msunsure 🔍
-1% - +2%
-0.31ms - +0.78ms		unsure 🔍
-4% - +2%
-1.33ms - +0.74ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
77.34ms - 80.06ms-unsure 🔍
-2% - +3%
-1.34ms - +2.10ms		unsure 🔍
-4% - +2%
-2.89ms - +1.25ms
tip-of-tree
tip-of-tree		77.27ms - 79.37msunsure 🔍
-3% - +2%
-2.10ms - +1.34ms		-unsure 🔍
-4% - +1%
-3.08ms - +0.68ms
previous-release
previous-release		77.96ms - 81.08msunsure 🔍
-2% - +4%
-1.25ms - +2.89ms		unsure 🔍
-1% - +4%
-0.68ms - +3.08ms		-
this-change, tip-of-tree, previous-release

render

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
46.93ms - 68.87ms-unsure 🔍
-38% - +6%
-27.35ms - +5.69ms		unsure 🔍
-29% - +23%
-17.44ms - +14.11ms
tip-of-tree
tip-of-tree		56.38ms - 81.08msunsure 🔍
-12% - +50%
-5.69ms - +27.35ms		-unsure 🔍
-15% - +46%
-7.59ms - +25.92ms
previous-release
previous-release		48.23ms - 70.90msunsure 🔍
-25% - +31%
-14.11ms - +17.44ms		unsure 🔍
-36% - +9%
-25.92ms - +7.59ms		-

update

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
538.50ms - 547.93ms-unsure 🔍
-1% - +1%
-6.29ms - +7.12ms		unsure 🔍
-1% - +1%
-6.39ms - +5.43ms
tip-of-tree
tip-of-tree		538.03ms - 547.57msunsure 🔍
-1% - +1%
-7.12ms - +6.29ms		-unsure 🔍
-1% - +1%
-6.85ms - +5.06ms
previous-release
previous-release		540.13ms - 547.26msunsure 🔍
-1% - +1%
-5.43ms - +6.39ms		unsure 🔍
-1% - +1%
-5.06ms - +6.85ms		-

update-reflect

VersionAvg timevs this-change
vs tip-of-tree
tip-of-tree		vs previous-release
previous-release
this-change
570.49ms - 577.23ms-unsure 🔍
-1% - +1%
-4.73ms - +5.25ms		unsure 🔍
-1% - +1%
-6.57ms - +4.52ms
tip-of-tree
tip-of-tree		569.93ms - 577.28msunsure 🔍
-1% - +1%
-5.25ms - +4.73ms		-unsure 🔍
-1% - +1%
-7.02ms - +4.45ms
previous-release
previous-release		570.48ms - 579.29msunsure 🔍
-1% - +1%
-4.52ms - +6.57ms		unsure 🔍
-1% - +1%
-4.45ms - +7.02ms		-

tachometer-reporter-action v2 for Benchmarks

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 2, 2024

The size of lit-html.js and lit-core.min.js are as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rictic rictic rictic approved these changes

@kevinpschaaf kevinpschaaf Awaiting requested review from kevinpschaaf kevinpschaaf is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

perf: remove IE 11 and Safari 9 code
2 participants
@justinfagnani @rictic