Fixed: #4682 - MSSQL: Doesn't support (n CHAR) syntax, but only (n) syntax #4683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly (n) syntax.
…mkarg-issue-4682
filipelautert
approved these changes
Aug 31, 2023
rberezen
approved these changes
Sep 1, 2023
sassasayu
added a commit
to sassasayu/liquibase
that referenced
this pull request
Sep 13, 2023
* Run only the `Build & Test(Java)` and `integration-tests` on every PR * remove copy-pasted needs section * using latestMergeSha * updated README and step name * comment build.yml * using pull_request_target for forked PRs * using pull_request for forked PRs * using authorize step * publish commitsha-SNPAHSOT in branch-builds * Trigger functional tests on label runFunctionalTests for a PR * formatting * formatting * formatting * use GITHUB_TOKEN * added a new org secret to RUN_FUNCTIONAL_TESTS * change the name of the event-ype for reposiotry disptach to run-functional-tests * Fix poor performance of listunrunchangesets (liquibase#4798) * Do not call normalizePath inside the loop for the same variable + just call it if everything else is fine. * Update new-build.yml Signed-off-by: sassasayu <143818841+sassasayu@users.noreply.github.com> * Update new-build.yml Signed-off-by: sassasayu <143818841+sassasayu@users.noreply.github.com> * Bump com.microsoft.sqlserver:mssql-jdbc from 12.2.0.jre8 to 12.4.1.jre8 (liquibase#4793) Bumps [com.microsoft.sqlserver:mssql-jdbc](https://github.com/Microsoft/mssql-jdbc) from 12.2.0.jre8 to 12.4.1.jre8. - [Release notes](https://github.com/Microsoft/mssql-jdbc/releases) - [Changelog](https://github.com/microsoft/mssql-jdbc/blob/main/CHANGELOG.md) - [Commits](https://github.com/Microsoft/mssql-jdbc/commits) --- updated-dependencies: - dependency-name: com.microsoft.sqlserver:mssql-jdbc dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * logic for matching branch in OSS and Pro * testing * run on push to all branches * Fixed: liquibase#4682 - MSSQL: Doesn't support (n CHAR) syntax, but only (n) syntax (liquibase#4683) * Fixed: liquibase#4682 - MSSQL: Doesn't support (n CHAR) syntax, but only (n) syntax. * Char and varchar with parameters tests added. --------- Co-authored-by: Daniel Mallorga <dmallorga@liquibase.com> * Bump targetMavenVersion from 3.9.2 to 3.9.4 (liquibase#4601) Bumps `targetMavenVersion` from 3.9.2 to 3.9.4. Updates `org.apache.maven:maven-plugin-api` from 3.9.2 to 3.9.4 - [Release notes](https://github.com/apache/maven/releases) - [Commits](apache/maven@maven-3.9.2...maven-3.9.4) Updates `org.apache.maven:maven-core` from 3.9.2 to 3.9.4 - [Release notes](https://github.com/apache/maven/releases) - [Commits](apache/maven@maven-3.9.2...maven-3.9.4) Updates `org.apache.maven:maven-artifact` from 3.9.2 to 3.9.4 - [Release notes](https://github.com/apache/maven/releases) - [Commits](apache/maven@maven-3.9.2...maven-3.9.4) Updates `org.apache.maven:maven-compat` from 3.9.2 to 3.9.4 - [Release notes](https://github.com/apache/maven/releases) - [Commits](apache/maven@maven-3.9.2...maven-3.9.4) --- updated-dependencies: - dependency-name: org.apache.maven:maven-plugin-api dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.maven:maven-core dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.maven:maven-artifact dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.maven:maven-compat dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump org.junit:junit-bom from 5.9.3 to 5.10.0 (liquibase#4767) Bumps [org.junit:junit-bom](https://github.com/junit-team/junit5) from 5.9.3 to 5.10.0. - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.9.3...r5.10.0) --- updated-dependencies: - dependency-name: org.junit:junit-bom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump com.h2database:h2 from 2.2.220 to 2.2.222 (liquibase#4828) Bumps [com.h2database:h2](https://github.com/h2database/h2database) from 2.2.220 to 2.2.222. - [Release notes](https://github.com/h2database/h2database/releases) - [Commits](h2database/h2database@version-2.2.220...version-2.2.222) --- updated-dependencies: - dependency-name: com.h2database:h2 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump liquibase/build-logic from 0.3.8 to 0.4.0 (liquibase#4727) Bumps [liquibase/build-logic](https://github.com/liquibase/build-logic) from 0.3.8 to 0.4.0. - [Release notes](https://github.com/liquibase/build-logic/releases) - [Commits](liquibase/build-logic@v0.3.8...v0.4.0) --- updated-dependencies: - dependency-name: liquibase/build-logic dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump net.snowflake:snowflake-jdbc from 3.14.0 to 3.14.1 (liquibase#4747) Bumps [net.snowflake:snowflake-jdbc](https://github.com/snowflakedb/snowflake-jdbc) from 3.14.0 to 3.14.1. - [Release notes](https://github.com/snowflakedb/snowflake-jdbc/releases) - [Changelog](https://github.com/snowflakedb/snowflake-jdbc/blob/master/CHANGELOG.rst) - [Commits](snowflakedb/snowflake-jdbc@v3.14.0...v3.14.1) --- updated-dependencies: - dependency-name: net.snowflake:snowflake-jdbc dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fixes JdbcExecutor's uses of RawParameterizedSqlStatement (liquibase#4589) Adds a private method, setParameters, to set parameters from RawParameterizedSqlStatement to PreparedStatement. Replaces parameters loop in execute with setParameters. Replaces parameters loop in query with setParameters. Co-authored-by: Andrew Simmons <andrew.p.simmons.civ@us.navy.mil> * Update README link to contribution docs (liquibase#4841) update link to contribution docs * Bump org.testcontainers:testcontainers-bom from 1.18.3 to 1.19.0 (liquibase#4710) Bumps [org.testcontainers:testcontainers-bom](https://github.com/testcontainers/testcontainers-java) from 1.18.3 to 1.19.0. - [Release notes](https://github.com/testcontainers/testcontainers-java/releases) - [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md) - [Commits](testcontainers/testcontainers-java@1.18.3...1.19.0) --- updated-dependencies: - dependency-name: org.testcontainers:testcontainers-bom dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * include tag in history tabular output (DAT-15244) (liquibase#4805) * Bump info.picocli:picocli from 4.7.4 to 4.7.5 (liquibase#4768) Bumps [info.picocli:picocli](https://github.com/remkop/picocli) from 4.7.4 to 4.7.5. - [Release notes](https://github.com/remkop/picocli/releases) - [Changelog](https://github.com/remkop/picocli/blob/main/RELEASE-NOTES.md) - [Commits](remkop/picocli@v4.7.4...v4.7.5) --- updated-dependencies: - dependency-name: info.picocli:picocli dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Allow update command to handle additional properties that are passed on the command line DAT-15769 (liquibase#4726) * Allow update command to handle additional properties that are passed as -D arguments on the command line DAT-15769 * Remove outputWriter from call to run update in old Main DAT-15769 * Fix liquibase.bat java home handling under Windows (liquibase#4845) * Revert "Fix liquibase 4.23.1 won't work on windows if there is no JAVA_HOME system variable set (liquibase#4803)" This reverts commit 7e709fe. * Revert "Fixes liquibase#3625 JAVA_HOME Path when parenthesis are present (liquibase#4306)" This reverts commit 202c0a8. * Bump org.xerial:sqlite-jdbc from 3.42.0.0 to 3.43.0.0 (liquibase#4784) Bumps [org.xerial:sqlite-jdbc](https://github.com/xerial/sqlite-jdbc) from 3.42.0.0 to 3.43.0.0. - [Release notes](https://github.com/xerial/sqlite-jdbc/releases) - [Changelog](https://github.com/xerial/sqlite-jdbc/blob/master/CHANGELOG) - [Commits](xerial/sqlite-jdbc@3.42.0.0...3.43.0.0) --- updated-dependencies: - dependency-name: org.xerial:sqlite-jdbc dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump ant.version from 1.10.13 to 1.10.14 (liquibase#4752) Bumps `ant.version` from 1.10.13 to 1.10.14. Updates `org.apache.ant:ant` from 1.10.13 to 1.10.14 Updates `org.apache.ant:ant-antlr` from 1.10.13 to 1.10.14 Updates `org.apache.ant:ant-junit` from 1.10.13 to 1.10.14 Updates `org.apache.ant:ant-launcher` from 1.10.13 to 1.10.14 --- updated-dependencies: - dependency-name: org.apache.ant:ant dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.ant:ant-antlr dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.ant:ant-junit dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.ant:ant-launcher dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fixed: SQL Anywhere reports fancy precision with LONG NVARCHAR (liquibase#4648) * Replacing special constants specific to SQL Anywhere by commonly supported JDBC Escape Functions (liquibase#4697) * Replacing special constants specific to SQL Anywhere by commonly supported JDBC Escape Functions * Joining if's --------- Co-authored-by: filipe <flautert@liquibase.org> Co-authored-by: rberezen <ruslan.berezenskyi@gmail.com> * Bump groovy.version from 2.5.22 to 2.5.23 (liquibase#4838) * Bump groovy.version from 2.5.22 to 2.5.23 Bumps `groovy.version` from 2.5.22 to 2.5.23. Updates `org.codehaus.groovy:groovy-bom` from 2.5.22 to 2.5.23 - [Commits](https://github.com/apache/groovy/commits) Updates `org.codehaus.groovy:groovy-all` from 2.5.22 to 2.5.23 - [Commits](https://github.com/apache/groovy/commits) --- updated-dependencies: - dependency-name: org.codehaus.groovy:groovy-bom dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.codehaus.groovy:groovy-all dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update groovy version to upgrade to. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.3.0 to 3.4.0 (liquibase#4717) Bumps [org.apache.maven.plugins:maven-enforcer-plugin](https://github.com/apache/maven-enforcer) from 3.3.0 to 3.4.0. - [Release notes](https://github.com/apache/maven-enforcer/releases) - [Commits](apache/maven-enforcer@enforcer-3.3.0...enforcer-3.4.0) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-enforcer-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fixed: Fails to detect LONG VARCHAR as CLOB and LONG BINARY as BLOB (liquibase#4670) * Fixed: Fails to detect LONG VARCHAR as CLOB and LONG BINARY as BLOB * Blob and Clob data types tests added. --------- Co-authored-by: Daniel Mallorga <dmallorga@liquibase.com> * remove workflow_call from build-branch, add dependabot to push-branches, change concurrency rule of run-tests to not cancel concurrent builds on master * add workflow_call from build-branch * Initialize the 'github' object * do not require signature assertion in CommandTests (liquibase#4851) * removing Initialize the 'github' object * Separate sections of the branch name with a hyphen for dependabot PR's (DAT-15548) (liquibase#4852) * pull-request-branch-nameseparator Signed-off-by: Sayali Mohadikar <76010603+sayaliM0412@users.noreply.github.com> * indentation check Signed-off-by: Sayali Mohadikar <76010603+sayaliM0412@users.noreply.github.com> --------- Signed-off-by: Sayali Mohadikar <76010603+sayaliM0412@users.noreply.github.com> * changes due to error of github.context * syntax error * removing github context * adding LIQUIBOT_PAT_GPM_ACCESS to access OSS and PRO * adding LIQUIBOT_PAT_GPM_ACCESS to access OSS and PRO * adding LIQUIBOT_PAT_GPM_ACCESS at the top of the job * Remove duplicated arguments (DAT-15461) (liquibase#4713) * remove unused mdc key * initial add of update report * remove end time * add integration test * remove unused import * fix command tests * null-safe labels and contexts * make keys bold, reformat table a bit, calculate changeset index correctly when there are both failed and successful changesets * [DAT-15461] Remove duplicated report arguments. * [DAT-15461] Fix bad merge, re-remove unnecessary args. --------- Co-authored-by: Steven Massaro <steven.massaro.web@gmail.com> Co-authored-by: rberezen <ruslan.berezenskyi@gmail.com> * use github.rest.repos and print github object * revert to using old code * Handle the case where no branches are found and use branchName.name.startsWith * syntax error * syntax fix for job condition * syntax fix in javascript * More consistent message when included file is empty DAT-15551 (liquibase#4812) * Added more error handling for empty changelog files DAT-15551 * Tests for messages DAT-15551 * Fix test DAT-15551 * Fix more tests DAT-15551 * Another test fix DAT-15551 --------- Co-authored-by: Taras Amelianovych <97164517+Tamelianovych@users.noreply.github.com> * testing changes for cleanup branch and pull_request for run-test yml file without the use of authorize * thisBranchName for OSS and PRO matching branch * changing the secret name to RUN_FUNCTIONAL_TEST_HARNESS_TESTS_TOKEN and adding testHarness yml * using latestMergeSha for the commitSha-SNAPSHOT and adjusting env for tar.gz package * using secrets.LIQUIBOT_PAT and fix indentation in new-build.yml file * checking to see if a new version of github-action-DAT-15775-SNAPSHOT gets generated in liqubiase.liquibase GPM * moving tar.gz to publish branch-SNAPSHOT instead of commitSHA-SNAPSHOT * Handle XML data types for DB2 DAT-12878 (liquibase#4827) * Rework code to handle DB2 differences DAT-12877 * Handle XML data types DAT-12878 * removing authorize job as we are getting it from settings in liquibase/liquibase and changing branch-matching logic * testing new logic for matching-branch as I found some edge cases where old logic wont work * testing new logic for matching-branch with abcd branchName * adding catch (error) * use currentBranch * Improve update summary usability (liquibase#4395) * Propagate skipped changesets to parent changelog * Add showSummary property * Test skipped changeset propagated to root changelog * Added updateReport expected result to some failing tests. --------- Co-authored-by: Daniel Mallorga <75833793+MalloD12@users.noreply.github.com> Co-authored-by: Daniel Mallorga <dmallorga@liquibase.com> * adding GITHUB_TOKEN for Publish branch-SNAPSHOT version to GPM * Implement showSummaryOutput parameter (liquibase#4574) * Implement showSummaryOutput parameter * Fixed collectArguments test for update command. * Apply review comments * Update summary output tests added. * Add showSummaryOutput to SpringLiquibase * Refactor show detail table * Added updateReport expected result to some failing tests. --------- Co-authored-by: Daniel Mallorga <dmallorga@liquibase.com> Co-authored-by: Daniel Mallorga <75833793+MalloD12@users.noreply.github.com> * setting of thisBranchName * echo modified_branch_name and use thisBranchName for tar.gz package to GPM * liquibase-commercial needs thisBranchName as this is a matching branch logic * reset master to 4.23.1 (d9a4a92) (liquibase#4873) This PR resets master to d9a4a92, which is the commit associated with the 4.23.1 release tag. ``` $ git reset --hard d9a4a92 $ git reset --soft ad6517d ``` ``` PS C:\dev\git\liquibase> git reset --hard d9a4a92 HEAD is now at d9a4a92 Merge pull request liquibase#4643 from liquibase/github-action-DAT-15622-build-installer PS C:\dev\git\liquibase> git reset --soft ad6517d ``` * DAT-15857 - Fix for checksum upgrade in runWith change sets (liquibase#4874) DAT-15857 --------- Co-authored-by: Wesley Willard <wwillard@datical.com> * Tweaked exception message for invalid formatted SQL file (liquibase#4870) DAT-15874 Co-authored-by: Wesley Willard <wwillard@datical.com> * getting error 403 Forbidden for forked PR * build-branch on pull_request * Release notes for 4.23.2 * using pull_request_target with authorize as forked PR is giving an error 403 * the tar.gz is failing even with the use of authorize with 403 * testing publish_tar_package_to_build_artifact * in standAlone PR branches-ignore for macthing branches * commenting out tests for testing and build branch only when run-test finishes * Revert "reset master to 4.23.1 (d9a4a92)" (liquibase#4890) Revert "reset master to 4.23.1 (d9a4a92) (liquibase#4873)" This reverts commit acfe8ed. * do not attempt to recreate DBCL when it is specified with mixed case (DAT-15570) (liquibase#4846) use legacy object quoting when dealing with system objects * Fix regression in recognizing formatted SQL file DAT-15865 (liquibase#4859) DAT-15865 Fix regression in recognizing formatted SQL file * testing publishing of tar.gz package * forked PR is not able to publish to GPM giving 403 forbidden * syntax error * using LIQUIBOT_PAT to Publish <commitsha>-SNAPSHOT * using authorize in build-branch * testing with workflow_run: completed * Fix LabelExpression constructors when using array or collection (liquibase#4854) * - LabelExpression constructors updated to set originalString. - Unit tests added. * - ContextExpression constructors updated to set originalString. - Unit tests added. * testing with workflow_run: completed * testing with workflow_run: completed * testing with workflow_run: completed * testing with workflow_run: completed * testing with workflow_run: completed * testing with workflow_run: completed * without using quotes * without using quotes * using workflow_run (liquibase#4899) Signed-off-by: Sayali Mohadikar <76010603+sayaliM0412@users.noreply.github.com> * workflow dispatch for Build Branch SNAPSHOT * testing * testing * testing --------- Signed-off-by: Sayali Mohadikar <76010603+sayaliM0412@users.noreply.github.com> Signed-off-by: sassasayu <143818841+sassasayu@users.noreply.github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Sayali M <sayali@Sayalis-MacBook-Pro> Co-authored-by: Sayali Mohadikar <76010603+sayaliM0412@users.noreply.github.com> Co-authored-by: filipe <flautert@liquibase.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Markus KARG <markus@headcrashing.eu> Co-authored-by: Daniel Mallorga <dmallorga@liquibase.com> Co-authored-by: andrew-simmons <1806065+andrew-simmons@users.noreply.github.com> Co-authored-by: Andrew Simmons <andrew.p.simmons.civ@us.navy.mil> Co-authored-by: nwcm <111259588+nwcm@users.noreply.github.com> Co-authored-by: Steven Massaro <steven.massaro.web@gmail.com> Co-authored-by: Wesley Willard <wwillard@liquibase.com> Co-authored-by: rberezen <ruslan.berezenskyi@gmail.com> Co-authored-by: Daniel Mallorga <75833793+MalloD12@users.noreply.github.com> Co-authored-by: Alex <abrackx@gmail.com> Co-authored-by: Taras Amelianovych <97164517+Tamelianovych@users.noreply.github.com> Co-authored-by: Claudio Nave <claudionave97@gmail.com> Co-authored-by: Wesley Willard <wwillard@datical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4682
Impact
Description
This PR cuts away the CHAR ending when it is found in the sole parameter, and the value's pattern is "the word CHAR follows a number". This is correct, as MSSQL expects the number to be given in characters, but just does not understand the subsequent word "CHAR".
Things to be aware of
N/A
Things to worry about
N/A
Additional Context
N/A