Adding logging for when no files match a pattern. #139
Conversation
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
- Coverage 90.24% 89.74% -0.51%
==========================================
Files 3 3
Lines 41 39 -2
Branches 6 5 -1
==========================================
- Hits 37 35 -2
Misses 4 4
Continue to review full report at Codecov.
|
|
I think we should use https://github.com/SamVerschueren/listr#skipping-tasks for that. It should keep the code cleaner. Can you try it out? |
|
Nicely, that also seems to fix the checkmark issue. |
|
@Noirbot nice! Can you post a screenshot of how it looks like now? |
|
I'm not super happy about skips looking like failures, but it's not a huge issue. Some output beats no output. I'll look through Listr and see if there's a way to skip while marking as successful, though, I can see the justification for keeping it this way for clarity. |
|
Well, they have 3 types: "ok", "skipped" and "failed". I think I like it. I'll merge and release it. |
|
This definitely seems like an improvement in visibility no matter what. I like it. |
|
Great work! Thanks for the contribution 👍 |
This is an initial attempt at a solution for #135. In short, I'm adjusting the
generateTasksfunction so it doesn't filter out patterns with no matching files, and then adding a special case for tasks with no files found.There's another option for this that involves just adding the logging to the
generateTasksfunction, which could keep the main method a little less complicated if that's preferred.I'm also noticing that there seems to be an inconsistency between the check character that lint-staged uses,
✅, and the one that Listr seems to use,✔. This isn't a new problem, but it does look a little odd now: