Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused argument #3149

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Remove unused argument #3149

merged 1 commit into from
Jul 26, 2019

Conversation

alpeb
Copy link
Member

@alpeb alpeb commented Jul 26, 2019

Removed unused argument in the GetPatch() function in pkg/inject/inject.go

@alpeb
Remove unused argument
ff4cf23 
Removed unused argument in the `GetPatch()` function in
`pkg/inject/inject.go`

Signed-off-by: Alejandro Pedraza <alejandro.pedraza@gmail.com>
@alpeb alpeb self-assigned this Jul 26, 2019
@l5d-bot
Copy link
Collaborator

l5d-bot commented Jul 26, 2019

Integration test results for ff4cf23: success 🎉
Log output: https://gist.github.com/c23ac637aff29002777f84a2dca1416e

siggy
siggy approved these changes Jul 26, 2019
View reviewed changes
Copy link
Member

@siggy siggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! 🚢

Side note, I am surprised unparam did not catch this, but that's for another PR.

@alpeb
Copy link
Member Author

alpeb commented Jul 26, 2019

@siggy Also the linter didn't catch this unnecessary global scope 🤷‍♂️

@alpeb alpeb merged commit 8c07223 into master Jul 26, 2019
@alpeb alpeb deleted the alpeb/unused-var branch July 26, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihcsim ihcsim ihcsim approved these changes

@siggy siggy siggy approved these changes

Assignees

@alpeb alpeb

Labels
area/inject size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alpeb @l5d-bot @siggy @ihcsim