Skip to content

Commit

Permalink
Remove unnecessary helm-release-version annotation (#11329)
Browse files Browse the repository at this point in the history
from destination and proxy-injector

Fixes #10778

Signed-off-by: Takumi Sue <u630868b@alumni.osaka-u.ac.jp>
  • Loading branch information
mikutas authored Sep 11, 2023
1 parent 9f04abf commit 1dc2603
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 14 deletions.
3 changes: 0 additions & 3 deletions charts/linkerd-control-plane/templates/destination.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,6 @@ spec:
template:
metadata:
annotations:
{{- if empty .Values.cliVersion }}
linkerd.io/helm-release-version: {{.Release.Revision | quote}}
{{- end }}
{{ include "partials.annotations.created-by" . }}
{{- include "partials.proxy.annotations" . | nindent 8}}
{{- with .Values.podAnnotations }}{{ toYaml . | trim | nindent 8 }}{{- end }}
Expand Down
3 changes: 0 additions & 3 deletions charts/linkerd-control-plane/templates/proxy-injector.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,6 @@ spec:
template:
metadata:
annotations:
{{- if empty .Values.cliVersion }}
linkerd.io/helm-release-version: {{.Release.Revision | quote}}
{{- end }}
{{ include "partials.annotations.created-by" . }}
{{- include "partials.proxy.annotations" . | nindent 8}}
{{- with .Values.podAnnotations }}{{ toYaml . | trim | nindent 8 }}{{- end }}
Expand Down
2 changes: 0 additions & 2 deletions cli/cmd/testdata/install_helm_control_plane_output.golden

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions cli/cmd/testdata/install_helm_control_plane_output_ha.golden

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions cli/cmd/testdata/install_helm_output_ha_labels.golden

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1dc2603

Please sign in to comment.