avoid memory leak in uvx_client_send(), when xclient is not connected…

… to a server.
liigo · Jan 16, 2019 · d33b2bd · d33b2bd
1 parent 03a7ebc
commit d33b2bd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/uvx.h b/uvx.h
@@ -159,6 +159,7 @@ int uvx_client_connect(uvx_client_t* xclient, uv_loop_t* loop, const char* ip, i
 // send data to the connected tcp server (not only xserver).
 // don't use `data` any more, it will be `free`ed later.
 // please make sure that `data` was `malloc`ed before, so that it can be `free`ed correctly.
+// if no server is connected, free data immediately, to avoid memory leak.
 // returns 1 on success, or 0 if fails.
 int uvx_client_send(uvx_client_t* xclient, void* data, unsigned int size);
 

diff --git a/uvx_client.c b/uvx_client.c
@@ -77,10 +77,12 @@ int uvx_client_connect(uvx_client_t* xclient, uv_loop_t* loop, const char* ip, i
 }
 
 int uvx_client_send(uvx_client_t* xclient, void* data, unsigned int size) {
-	if (xclient->uvserver)
+	if (xclient->uvserver) {
 		return uvx_send_to_stream((uv_stream_t*)xclient->uvserver, data, size);
-	else
+	} else {
+		free(data);
 		return 0;
+	}
 }
 
 static void _uv_on_connect(uv_connect_t* conn, int status);