-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvdb/bolt_compact: have log message take account space multiplier #5961
Conversation
It looks like there is an integration test failing:
Which seems unrelated to this change |
Thanks for the PR! You may consider use
As for the integration test, there are flakes so it's unrelated. |
Thanks for pointing that out @yyforyongyu. I've added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix, LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM⚡️
Awesome. Thank you both for the review. I don't think this necessitates editing release notes as per the guideline, since this is an extremely minor change. Which means, all is required is for an authorized user to merge. |
Indeed, that's what the |
We're currently in the RC phase of a release, so merging is blocked. Your PR will be merged as soon as the merge window opens again. |
@jyturley can you add this to the 0.14.1 release notes? |
I don't see a 0.14.1 release notes file, so I created a new one. I hope that was okay. |
Fixes #5937