Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvdb/bolt_compact: have log message take account space multiplier #5961

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

jyturley
Copy link
Contributor

Fixes #5937

@jyturley
Copy link
Contributor Author

It looks like there is an integration test failing:

=== RUN   TestLightningNetworkDaemon/tranche00/01-of-90/bitcoind/test_multi-hop_htlc/committype=SCRIPT_ENFORCED_LEASE/local_force_close_on-chain_htlc_timeout
    harness.go:354: 
        	Error Trace:	harness.go:354
        	            				lnd_multi-hop_test.go:264
        	            				lnd_multi-hop_local_force_close_on_chain_htlc_timeout_test.go:29
        	            				lnd_multi-hop_test.go:111
        	Error:      	Received unexpected error:
        	            	failed to receive state client stream: rpc error: code = DeadlineExceeded desc = context deadline exceeded
        	Test:       	TestLightningNetworkDaemon/tranche00/01-of-90/bitcoind/test_multi-hop_htlc/committype=SCRIPT_ENFORCED_LEASE/local_force_close_on-chain_htlc_timeout
        	Messages:   	unable to create new node for Carol

Which seems unrelated to this change

@yyforyongyu
Copy link
Member

Thanks for the PR! You may consider use [skip ci] as mentioned in the contribution guidelines,

If a PR only fixes a trivial issue, such as updating documentation on a small scale, fix typos, or any changes that do not modify the code, the commit message should end with [skip ci] to skip the CI checks.

As for the integration test, there are flakes so it's unrelated.

@jyturley
Copy link
Contributor Author

Thanks for pointing that out @yyforyongyu. I've added [skip ci] to the end of the commit message.

Copy link
Collaborator

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, LGTM 🎉

Copy link
Member

@yyforyongyu yyforyongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM⚡️

@jyturley
Copy link
Contributor Author

Awesome. Thank you both for the review. I don't think this necessitates editing release notes as per the guideline, since this is an extremely minor change. Which means, all is required is for an authorized user to merge.

@yyforyongyu
Copy link
Member

Awesome. Thank you both for the review. I don't think this necessitates editing release notes as per the guideline, since this is an extremely minor change. Which means, all is required is for an authorized user to merge.

Indeed, that's what the skip ci is for. I've updated the checklist to hopefully make it clear, as in #5953

@guggero
Copy link
Collaborator

guggero commented Nov 15, 2021

We're currently in the RC phase of a release, so merging is blocked. Your PR will be merged as soon as the merge window opens again.

@Roasbeef Roasbeef added this to the v0.14.1 milestone Nov 19, 2021
@Roasbeef
Copy link
Member

@jyturley can you add this to the 0.14.1 release notes?

@jyturley
Copy link
Contributor Author

I don't see a 0.14.1 release notes file, so I created a new one. I hope that was okay.

@guggero guggero merged commit e95ee41 into lightningnetwork:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compaction error message due to low disk space is wrong
4 participants