Fix testcases for cross compilation #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
photovoltex
reviewed
Jan 12, 2025
|
@catango friendly bump to address the review comments |
Crossbuild breaks due to missing bindgen. Additionally install bindgen-cli as it is not part of the default github runnter any more.
catango
force-pushed
the
fix-testcases
branch
from
bbca736 to
f037577
Compare
|
Thanks for the fix and code adjustments :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downgrade bindgen version to 0.70.1 to fix test cases. New bindgen versions break cross build