Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pubsub): remove "Implementation note" about setting message_id_fn #557

Merged
merged 2 commits into from
Jul 16, 2023
Merged

fix(pubsub): remove "Implementation note" about setting message_id_fn #557

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ad73a4
Update message_id_fn "Implementation note" to reflect current state o…
cce Jul 12, 2023
68ec144
remove note about topic specific message_id_fn
cce Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions pubsub/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,15 +198,6 @@ on the [signature policy](#signature-policy) configured for the topic.**
Whichever the choice, it is crucial that **all peers** participating in a topic
implement identical message ID calculation logic, or the topic will malfunction.

> **[[ Implementation note ]]:** At the time of writing this section,
> go-libp2p-pubsub (reference implementation of this spec) only allows
> configuring a single top-level `message_id_fn`. This function may, however,
> vary its behaviour based on the topic (contained inside its `Message`)
> argument. Thus, it's feasible to implement a per-topic policy using branch
> selection control flow logic. In the near future, go-libp2p-pubsub plans to
> push down the configuration of the `message_id_fn` to the topic level. Other
> implementations are encouraged to do the same.

## Message Signing

Signature behavior is configured in two axes: signature creation, and signature
Expand Down