Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: WebRTC-Direct support for Node.js #2583

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

feat: WebRTC-Direct support for Node.js #2583

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e2b6537
feat: WebRTC-Direct support for Node.js
achingbrain Jun 7, 2024
40c198a
chore: run interface compliance tests
achingbrain Jun 11, 2024
b572498
Merge remote-tracking branch 'origin/main' into feat/webrtc-direct-in…
achingbrain Jun 14, 2024
03044e0
chore: use libjuice for udp muxing
achingbrain Jun 14, 2024
1e052de
chore: allow function based config
achingbrain Jun 14, 2024
71bf4cb
Merge remote-tracking branch 'origin/main' into feat/webrtc-direct-in…
achingbrain Jun 18, 2024
f58bf18
Merge remote-tracking branch 'origin/main' into feat/webrtc-direct-in…
achingbrain Jan 14, 2025
7139c5a
chore: tests starting to pass
achingbrain Jan 16, 2025
cf56f63
chore: tests passing
achingbrain Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: allow function based config
  • Loading branch information
@achingbrain
achingbrain committed Jun 14, 2024
commit 1e052def6c0ccc2ba41b183f5b33ba7cc594e571
2 changes: 1 addition & 1 deletion packages/transport-webrtc/src/private-to-public/listener.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export interface WebRTCDirectListenerInit {
certificates?: TransportCertificate[]
maxInboundStreams?: number
dataChannel?: DataChannelOptions
rtcConfiguration?: RTCConfiguration
rtcConfiguration?: RTCConfiguration | (() => RTCConfiguration | Promise<RTCConfiguration>)
useLibjuice?: boolean
}

Expand Down
2 changes: 1 addition & 1 deletion packages/transport-webrtc/src/private-to-public/transport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export interface WebRTCMetrics {
}

export interface WebRTCTransportDirectInit {
rtcConfiguration?: RTCConfiguration
rtcConfiguration?: RTCConfiguration | (() => RTCConfiguration | Promise<RTCConfiguration>)
dataChannel?: DataChannelOptions
certificates?: TransportCertificate[]
useLibjuice?: boolean
Expand Down
6 changes: 4 additions & 2 deletions packages/transport-webrtc/src/private-to-public/utils/get-rtcpeerconnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export class DirectRTCPeerConnection extends RTCPeerConnection {
}
}

export async function createDialerRTCPeerConnection (name: string, ufrag: string, rtcConfiguration?: RTCConfiguration, certificate?: TransportCertificate): Promise<DirectRTCPeerConnection> {
export async function createDialerRTCPeerConnection (name: string, ufrag: string, rtcConfiguration?: RTCConfiguration | (() => RTCConfiguration | Promise<RTCConfiguration>), certificate?: TransportCertificate): Promise<DirectRTCPeerConnection> {
if (certificate == null) {
const keyPair = await crypto.subtle.generateKey({
name: 'ECDSA',
Expand All @@ -90,14 +90,16 @@ export async function createDialerRTCPeerConnection (name: string, ufrag: string
})
}

const rtcConfig = typeof rtcConfiguration === 'function' ? await rtcConfiguration() : rtcConfiguration

// https://github.com/libp2p/specs/blob/master/webrtc/webrtc-direct.md#browser-to-public-server
const peerConnection = new PeerConnection(name, {
disableFingerprintVerification: true,
disableAutoNegotiation: true,
certificatePemFile: certificate.pem,
keyPemFile: certificate.privateKey,
maxMessageSize: 16384,
iceServers: toLibdatachannelIceServers(rtcConfiguration?.iceServers) ?? DEFAULT_STUN_SERVERS
iceServers: toLibdatachannelIceServers(rtcConfig?.iceServers) ?? DEFAULT_STUN_SERVERS
})

return new DirectRTCPeerConnection({
Expand Down
Loading