Closed
Description
There is a regression in the master branch regarding the 0.18.1
release. After the changes in libgit2 0.19
we have lost the Remote.fetchspec
setter. To get back the ability to modify remote's refspecs, and to do so properly, we need to:
- Implement a
Refspec
type, in a new filesrc/refspec.c
- Wrap more libgit2 functions in the
Remote
type
Volunteers?
Metadata
Assignees
Labels
No labels
Activity
xtao commentedon Jul 4, 2013
Hi, @jdavid I will do this.
Can you show more details?
jdavid commentedon Jul 4, 2013
Hi @xtao and thank you for volunteering!
This is the API to implement.
Constants:
Refspec type,
src/refspec.c
:Remote type,
remote.c
:Note that:
0.19
, http://libgit2.github.com/libgit2/#v0.19.0Do you have questions?
carlosmn commentedon Jan 19, 2014
With libgit2 v0.20, we have the ability to set the fetch and push refspecs again. Removing the nth refspec isn't something we want to do anyway, so the only parts missing should be
add_fetch
, andadd_push
.xtao commentedon Jan 20, 2014
Fixed #318
carlosmn commentedon Jan 23, 2014
With the PRs that got merged recently, this can be closed, no?
jdavid commentedon Jan 24, 2014
yes, thanks!
IfeanyiEkperi commentedon Jan 24, 2014
Fixed #33