New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use explicit casts for some functions #2480

Open

gperciva wants to merge 1 commit into libarchive:master from Tarsnap:explicit-casts

Contributor

gperciva commented Jan 9, 2025

No description provided.


          Use explicit casts for some functions

b4fc84c

Contributor Author

gperciva commented Jan 9, 2025

clang -Wimplicit-int-conversion

This set are the most clear-cut cases of where explicit casts are useful.

tolower() returns an int, so we want to to store it in a char * it needs a cat.
FreeBSD 14.1 defines acl_flag_t as uint16_t, so that needs a cast. acl_type_t is an int, so no need to cast that.
the other casts should be clear from the context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet