feat: error resilient errors #5354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will add more errors in this PR itself. |
parth121101
added
the
error resiliency
parth121101
force-pushed
the
error_res_6
branch
from
de512ed to
98359ca
Compare
|
Looks good. Get CI to pass and let's merge it. |
Pranavchiku
previously requested changes
Nov 12, 2024
parth121101
force-pushed
the
error_res_6
branch
from
98359ca to
9a8b2b7
Compare
parth121101
force-pushed
the
error_res_6
branch
from
9a8b2b7 to
2dcbcfe
Compare
aye aye, sir |
certik
reviewed
Nov 13, 2024
Comment on lines
+60
to
+78
| ! close_invalid_kwarg1 | ||
| CLOSE(end=200) | ||
| print *, "Fifth error skipped" | ||
|
|
||
|
|
||
| ! cmplx_01 | ||
| a = cmplx(y = 2) | ||
| print *, a | ||
| print *, "Sixth error skipped" | ||
|
|
||
|
|
||
| ! cmplx_02 | ||
| print*, cmplx((real(1, kind=4), 0.00000000), kind=8) | ||
| print *, "Seventh error skipped" | ||
|
|
||
|
|
||
| ! cmplx_03 | ||
| print*, cmplx((1.00000000, real(0, kind=4)), kind=8) | ||
| print *, "Eighth error skipped" |
There was a problem hiding this comment.
Let's shorten these to just:
CLOSE(end=200)
a = cmplx(y = 2)
print*, cmplx((real(1, kind=4), 0.00000000), kind=8)
print*, cmplx((1.00000000, real(0, kind=4)), kind=8)Seems a lot shorter and removes noise.
There was a problem hiding this comment.
Will apply this changes here : #5374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: #5036