Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh : Create physical string descriptor to be used with allocatable strings #4918

Merged
merged 26 commits into from
Oct 31, 2024
Merged

enh : Create physical string descriptor to be used with allocatable strings #4918

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
61fdde4
create character type of descriptor type when type is allocatable and…
assem2002 Sep 25, 2024
716d8a0
Create return type of character with correct physical type
assem2002 Sep 25, 2024
9e25ff5
Change runtime function signature to utilize size and capacity member…
assem2002 Oct 8, 2024
1c6c2cf
Add stringPhysicalCast node to cast from DescriptorString to PointerS…
assem2002 Oct 8, 2024
c78a5ed
Create cast_string functions to check if the expr really needs to be …
assem2002 Oct 8, 2024
eb63d2b
Create the physical descriptorString + start utilizing its size and c…
assem2002 Oct 8, 2024
784bf86
Minor : use ndim initialized to 0 + add conditions if the string is p…
assem2002 Oct 8, 2024
f62b589
Deallocate string that's descriptorString
assem2002 Oct 8, 2024
41be24d
Create stringPhysicalCast visitor to cast between the 2 physicalStrin…
assem2002 Oct 8, 2024
be01e31
Always use stringDescriptor variable in the code base as pointer and …
assem2002 Oct 8, 2024
93f1f38
Add documentation for stringPhysicalType + stringPhysicalCast
assem2002 Oct 9, 2024
386e487
minor change in documentation
assem2002 Oct 9, 2024
8099c61
minor change in stringPhysicalType.md
assem2002 Oct 9, 2024
2a3431f
make sure to fetch internal character_t type
assem2002 Oct 9, 2024
e7c3937
check and Cast in associate node
assem2002 Oct 9, 2024
6a61294
minor comment removal
assem2002 Oct 9, 2024
7c0281c
Add associate test for testing descriptorString to be RHS
assem2002 Oct 9, 2024
688f01a
minor in stringPhysicalCast.md
assem2002 Oct 9, 2024
24fb6fc
Modify the docs : some examples and minor typos
assem2002 Oct 14, 2024
1c766c3
Use cast functions direclty (it doesn't check - we should check befor…
assem2002 Oct 14, 2024
e0a1371
minor : add assertions when passing an expression node to cast_string…
assem2002 Oct 14, 2024
0b8bd1f
Changes in documentation
assem2002 Oct 15, 2024
777edb2
Remove if condition (if you want to use cast node, you've to check it…
assem2002 Oct 15, 2024
7c0a6e5
Update reference tests
assem2002 Oct 15, 2024
5e64d08
don't cast string if it's an arg for 'present' intrinsic
assem2002 Oct 15, 2024
b20f84b
Merge branch 'main' into descriptor_string_FEEDBACK
certik Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor change in documentation
  • Loading branch information
@assem2002
assem2002 committed Oct 28, 2024
commit 386e487c197e3f1a7dc9ea7a9ef26819ad813550
2 changes: 1 addition & 1 deletion doc/src/asr/asr_nodes/expression_nodes/StringPhysicalCast.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@

# String Physical Cast
Cast string physical type from [`DescriptorString`](../type_nodes/StringPhysicalType.md) to [`PointerString`](../type_nodes/StringPhysicalType.md) and vice versa
## Declaration

Expand Down
2 changes: 2 additions & 0 deletions doc/src/asr/asr_nodes/type_nodes/StringPhysicalType.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# String Physical Type

### Types

```ASDL
Expand Down